Add basic JUL to Log4j API conversion #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR converts the most commonly used JUL methods to their Log4j API equivalents: * `Logger#getLogger`, * all `Logger#<logging_level` methods, * `Logger#entering`, * `Logger#exiting`.
timtebeek
reviewed
Dec 12, 2023
src/test/java/org/openrewrite/java/logging/log4j/ConvertJulEnteringTest.java
Show resolved
Hide resolved
- Strip final from local variables - Pass `UsesMethod` directly into Preconditions - Create a MethodMatcher field used twice - Inline `EnteringMethodVisitor` - Match on `entering(String, String, ..)` - Drop `@JsonPOJOBuilder`
timtebeek
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Thanks a lot yet again! I've made some polishing commits to align with our other recipe implementations, most notably cc791e5 with more details in the commit. Other than that just great seeing how quickly you're productive building recipes here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR converts the most commonly used JUL methods to their Log4j API equivalents:
Logger#getLogger,Logger#<logging_levelmethods,Logger#entering,Logger#exiting.What's your motivation?
This is part of our apache/logging-log4j2#2080 task.
The main motivation is a user request for support (cf. apache/logging-log4j2#2083), hence the implementation of the
entering/exitingrules.Closes #132
Checklist