Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log4j from runtime classpath as it is only needed to generate a recipe from a refaster template #204

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

pstreef
Copy link
Contributor

@pstreef pstreef commented Dec 20, 2024

This does not yet work as expected in the test

What's changed?

Moved dependency to compileOnly

What's your motivation?

Vulnerability

Anything in particular you'd like reviewers to focus on?

why does the test not work? logback 1 should be on the classpath because classpathFromResources but it is not available:

Screenshot 2024-12-20 at 10 20 26

Anyone you would like to review specifically?

@timtebeek @knutwannheden

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to remove the transitive dependency; we'll need to reevaluate how Refaster generated recipes use the classpath, and how that might differ between the various ways we have to run recipes.

@pstreef pstreef merged commit 8bf0aa2 into main Dec 20, 2024
2 checks passed
@pstreef pstreef deleted the fix/compile-only-to-avoid-log4j-vuln branch December 20, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants