Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Tycho generated POMs #635

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Ignore Tycho generated POMs #635

merged 1 commit into from
Oct 1, 2023

Conversation

Bananeweizen
Copy link
Contributor

@Bananeweizen Bananeweizen commented Sep 30, 2023 •
edited
Loading

Eclipse Tycho produces artificial Maven POMs during the build, which should be ignored by the POM scanner.

Fixes #634.

What's changed?

Ignore temporary POMs generated by Eclipse Tycho during the scan for POMs.
The debug log now shows the real POMs being picked up during the scan (compare to issue):

[DEBUG] Project [eclipse-cs Maven Parent] Base directory : 'C:\dev\eclipse-cs\git\eclipse-cs'
[DEBUG] Project [eclipse-cs Maven Parent]   Collected Maven POM : 'C:\dev\eclipse-cs\git\eclipse-cs\pom.xml'
[DEBUG] Project [eclipse-cs Maven Parent]   Collected Maven POM : 'C:\dev\eclipse-cs\git\eclipse-cs\net.sf.eclipsecs.branding\pom.xml'
[DEBUG] Project [eclipse-cs Maven Parent]   Collected Maven POM : 'C:\dev\eclipse-cs\git\eclipse-cs\net.sf.eclipsecs.checkstyle\pom.xml'
[DEBUG] Project [eclipse-cs Maven Parent]   Collected Maven POM : 'C:\dev\eclipse-cs\git\eclipse-cs\net.sf.eclipsecs.core\pom.xml'
[DEBUG] Project [eclipse-cs Maven Parent]   Collected Maven POM : 'C:\dev\eclipse-cs\git\eclipse-cs\net.sf.eclipsecs.doc\pom.xml'
[DEBUG] Project [eclipse-cs Maven Parent]   Collected Maven POM : 'C:\dev\eclipse-cs\git\eclipse-cs\net.sf.eclipsecs.sample\pom.xml'
[DEBUG] Project [eclipse-cs Maven Parent]   Collected Maven POM : 'C:\dev\eclipse-cs\git\eclipse-cs\net.sf.eclipsecs.ui\pom.xml'
[DEBUG] Project [eclipse-cs Maven Parent]   Collected Maven POM : 'C:\dev\eclipse-cs\git\eclipse-cs\net.sf.eclipsecs-feature\pom.xml'
[DEBUG] Project [eclipse-cs Maven Parent]   Collected Maven POM : 'C:\dev\eclipse-cs\git\eclipse-cs\net.sf.eclipsecs-updatesite\pom.xml'

What's your motivation?

#634

@Bananeweizen
Ignore Tycho generated POMs
f06cac8 
Eclipse Tycho produces artificial Maven POMs during the build, which
should be ignored by the POM scanner.

Fixes openrewrite#634.
@timtebeek timtebeek added the enhancement New feature or request label Oct 1, 2023
@timtebeek timtebeek self-requested a review October 1, 2023 08:54
timtebeek
timtebeek approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Bananeweizen !

@timtebeek timtebeek merged commit 12ff85a into openrewrite:main Oct 1, 2023
1 check passed
@Bananeweizen Bananeweizen deleted the tycho_generated branch October 1, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@Bananeweizen Bananeweizen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should ignore Tycho generated POMs
2 participants
@Bananeweizen @timtebeek