Handle labels #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkschneider
changed the title
…nctionality. There are a bunch of todos with unanswered questions or polish. Coverage is primarily based on invocation analysis and usage patterns of an internal codebase. Does not cover fields. Not covered: io.prometheus.client.Collector.MetricFamilySamples.<constructor> io.prometheus.client.Collector.MetricFamilySamples.Sample.<constructor> io.prometheus.client.Collector.register io.prometheus.client.CollectorRegistry.clear io.prometheus.client.CollectorRegistry.filteredMetricFamilySamples io.prometheus.client.CollectorRegistry.getSampleValue io.prometheus.client.CollectorRegistry.metricFamilySamples io.prometheus.client.CollectorRegistry.register io.prometheus.client.CollectorRegistry.unregister io.prometheus.client.hotspot.DefaultExports.register io.prometheus.client.jetty.JettyStatisticsCollector.<constructor> io.prometheus.client.jetty.QueuedThreadPoolStatisticsCollector.<constructor> io.prometheus.client.jetty.QueuedThreadPoolStatisticsCollector.register
escardin
force-pushed
the
escardin/AddLabelsTest
branch
from
374d20d to
f5baaf0
Compare
|
Closing the PR due to the conflicting changes since, and as unlikely to be picked up further for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.