refactor: Common static analysis issues

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.CommonStaticAnalysis?organizationId=T3BlblJld3JpdGU%3D

Co-authored-by: Moderne <[email protected]>

src/main/kotlin/org/openrewrite/ChangedRecipe.kt

@@ -11,11 +11,21 @@ data class ChangedRecipe(
     val oldOptions: TreeSet<RecipeOption>?,
 ): Comparable<ChangedRecipe> {
     override fun compareTo(other: ChangedRecipe): Int {
-        if (this.artifactId != other.artifactId) return this.artifactId.compareTo(other.artifactId)
-        if (this.name != other.name) return this.name.compareTo(other.name)
-        if (this.description != other.description) return this.description.compareTo(other.description)
-        if (this.newOptions != other.newOptions) return -1
-        if (this.oldOptions != other.oldOptions) return -1
+        if (this.artifactId != other.artifactId) {
+            return this.artifactId.compareTo(other.artifactId)
+        }
+        if (this.name != other.name) {
+            return this.name.compareTo(other.name)
+        }
+        if (this.description != other.description) {
+            return this.description.compareTo(other.description)
+        }
+        if (this.newOptions != other.newOptions) {
+            return -1
+        }
+        if (this.oldOptions != other.oldOptions) {
+            return -1
+        }
         return 0
     }
 }

src/main/kotlin/org/openrewrite/MarkdownRecipeArtifact.kt

@@ -8,8 +8,12 @@ data class MarkdownRecipeArtifact (
     val markdownRecipeDescriptors: TreeMap<String, MarkdownRecipeDescriptor>,
 ) : Comparable<MarkdownRecipeArtifact> {
     override fun compareTo(other: MarkdownRecipeArtifact): Int {
-        if (this.artifactId != other.artifactId) return this.artifactId.compareTo(other.artifactId)
-        if (this.markdownRecipeDescriptors != other.markdownRecipeDescriptors) return -1
+        if (this.artifactId != other.artifactId) {
+            return this.artifactId.compareTo(other.artifactId)
+        }
+        if (this.markdownRecipeDescriptors != other.markdownRecipeDescriptors) {
+            return -1
+        }
         return 0
     }
 }

src/main/kotlin/org/openrewrite/MarkdownRecipeDescriptor.kt

@@ -11,9 +11,15 @@ data class MarkdownRecipeDescriptor (
     val artifactId: String = "",
 ): Comparable<MarkdownRecipeDescriptor> {
     override fun compareTo(other: MarkdownRecipeDescriptor): Int {
-        if (this.name != other.name) return this.name.compareTo(other.name)
-        if (this.description != other.description) return this.description.compareTo(other.description)
-        if (this.options != other.options) return -1
+        if (this.name != other.name) {
+            return this.name.compareTo(other.name)
+        }
+        if (this.description != other.description) {
+            return this.description.compareTo(other.description)
+        }
+        if (this.options != other.options) {
+            return -1
+        }
         return 0
     }
 }