Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSPEC tag links for context when browsing recipes #112

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

timtebeek
Copy link
Contributor

A lot of our static analysis recipes link to an external specification. We can provide additional context by converting those into a link.

For example:

@timtebeek timtebeek added the documentation Improvements or additions to documentation label Apr 22, 2024
@timtebeek timtebeek requested a review from mike-solomon April 22, 2024 13:04
@timtebeek timtebeek self-assigned this Apr 22, 2024
Copy link
Contributor

@mike-solomon mike-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm - thanks for adding this!

@mike-solomon mike-solomon merged commit 1b83a91 into main Apr 22, 2024
1 check passed
@mike-solomon mike-solomon deleted the link-to-rspec branch April 22, 2024 13:22
@timtebeek
Copy link
Contributor Author

Indeed now works: https://openrewrite.github.io/rewrite-recipe-markdown-generator/reference/recipes/java/logging/parameterizedlogging.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants