Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use false for boolean values; not null #81

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Use false for boolean values; not null #81

merged 2 commits into from
Nov 2, 2023

Conversation

timtebeek
Copy link
Contributor

As seen on: https://docs.openrewrite.org/recipes/java/migrate/usetabsorspaces
image

That null is rather awkward; false is likely a better option for required configuration parameters.

@timtebeek timtebeek self-assigned this Nov 2, 2023
@timtebeek timtebeek added documentation Improvements or additions to documentation docs labels Nov 2, 2023
mike-solomon
mike-solomon approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@mike-solomon mike-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spacing issue but otherwise looks good. Thanks for keeping an eye out for this.

src/main/kotlin/org/openrewrite/RecipeMarkdownGenerator.kt Outdated Show resolved Hide resolved
@timtebeek timtebeek temporarily deployed to github-pages November 2, 2023 15:07 — with GitHub Actions Inactive
@timtebeek timtebeek merged commit 684d26a into main Nov 2, 2023
1 check passed
@timtebeek timtebeek deleted the false_for_boolean_values branch November 2, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-solomon mike-solomon mike-solomon approved these changes

Assignees

@timtebeek timtebeek

Labels
docs documentation Improvements or additions to documentation
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timtebeek @mike-solomon