-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Always emit fully qualified code from
TemplateProcessor (#55)
* Always emit fully qualified code from `TemplateProcessor` `TemplateProcessor` now always emits fully qualified type, field and method references regardless of what the input Java code looks like. The idea being that then a `ShortenFullyQualifiedTypeReferences` will remove unnecessary full qualifications. * Remove unused code * Don't print `java.lang` packages * Let `TemplateCode` produce entire `JavaTemplate.Builder` * Polish * Allow full qualification to be configured * Polish tests --------- Co-authored-by: Tim te Beek <[email protected]>
- Loading branch information
1 parent
10cd1b0
commit 7516697
Showing
8 changed files
with
242 additions
and
114 deletions.
There are no files selected for viewing
149 changes: 149 additions & 0 deletions
149
src/main/java/org/openrewrite/java/template/internal/TemplateCode.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| /* | ||
| * Copyright 2023 the original author or authors. | ||
| * <p> | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * <p> | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.openrewrite.java.template.internal; | ||
|
|
||
| import com.sun.tools.javac.code.Symbol; | ||
| import com.sun.tools.javac.tree.JCTree; | ||
| import com.sun.tools.javac.tree.JCTree.JCIdent; | ||
| import com.sun.tools.javac.tree.Pretty; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.StringWriter; | ||
| import java.io.UncheckedIOException; | ||
| import java.io.Writer; | ||
| import java.util.*; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public class TemplateCode { | ||
|
|
||
| public static <T extends JCTree> String process(T tree, List<JCTree.JCVariableDecl> parameters, boolean fullyQualified) { | ||
| StringWriter writer = new StringWriter(); | ||
| TemplateCodePrinter printer = new TemplateCodePrinter(writer, parameters, fullyQualified); | ||
| try { | ||
| printer.printExpr(tree); | ||
| StringBuilder builder = new StringBuilder("JavaTemplate\n"); | ||
| builder | ||
| .append(" .builder(\"") | ||
| .append(writer.toString().replace("\\", "\\\\").replace("\"", "\\\"")) | ||
| .append("\")"); | ||
| if (!printer.imports.isEmpty()) { | ||
| builder.append("\n .imports(").append(printer.imports.stream().map(i -> '"' + i + '"').collect(Collectors.joining(", "))).append(")"); | ||
| } | ||
| if (!printer.staticImports.isEmpty()) { | ||
| builder.append("\n .staticImports(").append(printer.staticImports.stream().map(i -> '"' + i + '"').collect(Collectors.joining(", "))).append(")"); | ||
| } | ||
| List<Symbol> imports = ImportDetector.imports(tree); | ||
| String classpath = ClasspathJarNameDetector.classpathFor(tree, imports); | ||
| if (!classpath.isEmpty()) { | ||
| builder.append("\n .javaParser(JavaParser.fromJavaVersion().classpath(").append(classpath).append("))"); | ||
| } | ||
| return builder.toString(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| private static class TemplateCodePrinter extends Pretty { | ||
|
|
||
| private static final String PRIMITIVE_ANNOTATION = "org.openrewrite.java.template.Primitive"; | ||
| private final List<JCTree.JCVariableDecl> declaredParameters; | ||
| private final boolean fullyQualified; | ||
| private final Set<JCTree.JCVariableDecl> seenParameters = new HashSet<>(); | ||
| private final TreeSet<String> imports = new TreeSet<>(); | ||
| private final TreeSet<String> staticImports = new TreeSet<>(); | ||
|
|
||
| public TemplateCodePrinter(Writer writer, List<JCTree.JCVariableDecl> declaredParameters, boolean fullyQualified) { | ||
| super(writer, true); | ||
| this.declaredParameters = declaredParameters; | ||
| this.fullyQualified = fullyQualified; | ||
| } | ||
|
|
||
| @Override | ||
| public void visitIdent(JCIdent jcIdent) { | ||
| try { | ||
| Symbol sym = jcIdent.sym; | ||
| Optional<JCTree.JCVariableDecl> param = declaredParameters.stream().filter(p -> p.sym == sym).findFirst(); | ||
| if (param.isPresent()) { | ||
| print("#{" + sym.name); | ||
| if (seenParameters.add(param.get())) { | ||
| String type = param.get().type.toString(); | ||
| if (param.get().getModifiers().getAnnotations().stream().anyMatch(a -> a.attribute.type.tsym.getQualifiedName().toString().equals(PRIMITIVE_ANNOTATION))) { | ||
| type = getUnboxedPrimitive(type); | ||
| } | ||
| print(":any(" + type + ")"); | ||
| } | ||
| print("}"); | ||
| } else if (sym != null) { | ||
| print(sym); | ||
| } else { | ||
| print(jcIdent.name); | ||
| } | ||
| } catch (IOException e) { | ||
| throw new UncheckedIOException(e); | ||
| } | ||
| } | ||
|
|
||
| void print(Symbol sym) throws IOException { | ||
| if (sym instanceof Symbol.ClassSymbol) { | ||
| if (fullyQualified) { | ||
| print(sym.packge().fullname.contentEquals("java.lang") ? sym.name : sym.getQualifiedName()); | ||
| } else { | ||
| print(sym.name); | ||
| if (!sym.packge().fullname.contentEquals("java.lang")) { | ||
| imports.add(sym.getQualifiedName().toString()); | ||
| } | ||
| } | ||
| } else if (sym instanceof Symbol.MethodSymbol || sym instanceof Symbol.VarSymbol) { | ||
| if (fullyQualified) { | ||
| print(sym.owner); | ||
| print('.'); | ||
| print(sym.name); | ||
| } else { | ||
| print(sym.name); | ||
| if (!sym.packge().fullname.contentEquals("java.lang")) { | ||
| staticImports.add(sym.owner.getQualifiedName() + "." + sym.name); | ||
| } | ||
| } | ||
| } else if (sym instanceof Symbol.PackageSymbol) { | ||
| print(sym.getQualifiedName()); | ||
| } | ||
| } | ||
|
|
||
| private String getUnboxedPrimitive(String paramType) { | ||
| switch (paramType) { | ||
| case "java.lang.Boolean": | ||
| return "boolean"; | ||
| case "java.lang.Byte": | ||
| return "byte"; | ||
| case "java.lang.Character": | ||
| return "char"; | ||
| case "java.lang.Double": | ||
| return "double"; | ||
| case "java.lang.Float": | ||
| return "float"; | ||
| case "java.lang.Integer": | ||
| return "int"; | ||
| case "java.lang.Long": | ||
| return "long"; | ||
| case "java.lang.Short": | ||
| return "short"; | ||
| case "java.lang.Void": | ||
| return "void"; | ||
| } | ||
| return paramType; | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.