Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quarkus-update-recipes #2

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Add quarkus-update-recipes #2

merged 7 commits into from
Feb 27, 2024

Conversation

timtebeek
Copy link
Contributor

Adds quarkus-update-recipes

We likely still need to rename and move the .yaml files to fall under /META-INF/rewrite and end with .yml.
Look at https://imperceptiblethoughts.com/shadow/configuration/merging/#merging-service-descriptor-files

As by default the yaml resources are not immediately in the typical location.
image

@timtebeek timtebeek self-assigned this Feb 21, 2024
@timtebeek
Copy link
Contributor Author

timtebeek commented Feb 27, 2024

So there's a few oddities here where there's two artifacts:
https://repo1.maven.org/maven2/io/quarkus/quarkus-update-recipes/1.0.14/

The -core contains the usual META-INF/rewrite/ files (only), but they are suffixed .yaml, not .yml. This file also lacks the camel yaml recipes.
The plain jar contains classes, and a /quarkus-updates/org.apache.camel.quarkus/camel-quarkus/3alpha.yaml file, but no META-INF/rewrite/ at all.

Both are quite awkward and not as easily shadowed into the output jar. There appears to be some support for relocation in Shadow, but that follows a package structure that incidentally also renames files, which does not play well with the paths listed above.

Any non-class files that are stored within a package structure are also relocated to the new location.

Attempts at using a com.github.jengelman.gradle.plugins.shadow.transformers.Transformer are so far unsuccessful.

@timtebeek
Copy link
Contributor Author

@timtebeek timtebeek marked this pull request as ready for review February 27, 2024 22:51
@timtebeek timtebeek merged commit d5745f4 into main Feb 27, 2024
2 checks passed
@timtebeek timtebeek deleted the quarkus-update-recipes branch February 27, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant