Groovy parser fails when using duplicate static star imports

[Jnb1234]

What version of OpenRewrite are you using?

I am using

• OpenRewrite 6.8.4
• Gradle plugin 7.4.2
• rewrite-module v1.2.3

How are you running OpenRewrite?

I am using the Gradle plugin, and my project is a single module project.

plugins {
    id 'maven-publish'
    id 'groovy'
    id 'idea'
    id 'net.researchgate.release' version '2.8.1'
    id "com.github.ben-manes.versions" version "0.36.0"
    id "com.gorylenko.gradle-git-properties" version "2.3.2"
    id 'java-library'
    id 'org.openrewrite.rewrite' version '6.8.4'
}

rewrite {
    activeRecipe("org.openrewrite.java.RemoveUnusedImports")
}

What is the smallest, simplest way to reproduce the problem?

@Test
void staticStarImport() {
  rewriteRun(
    groovy(
      """
        import static java.util.Collections.*
        import static java.util.Collections.*
      """
    )
  );
}

What did you expect to see?

No parsing error

What did you see instead?

parsing error

What is the full stack trace of any errors you encountered?

Error during rewrite dry run
org.opentest4j.AssertionFailedError: [When parsing and printing the source code back to text without modifications, the printed source didn't match the original source code. This means there is a bug in the parser implementation itself. Please open an issue to report this, providing a sample of the code that generated this error for "file.groovy":
diff --git a/file.groovy b/file.groovy
index dff510f..56679bc 100644
--- a/file.groovy
+++ b/file.groovy
@@ -1,2 +1,2 @@ 
 import static java.util.Collections.*
-import static java.util.Collections.*
\ No newline at end of file
+import static java.util.Collections.//*
\ No newline at end of file
] 
expected: 
  "import static java.util.Collections.*
  import static java.util.Collections.*"
 but was: 
  "import static java.util.Collections.*
  import static java.util.Collections.//*"

Are you interested in contributing a fix to OpenRewrite?

[timtebeek]

Thanks for the clear example @Jnb1234 ! It seems to fail on this particular line

rewrite/rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java

Line 232 in 06a1bc8

assert kindType != null;

Is there any reason why the types might be absent in your case above? Are those imports on the classpath?

[Jnb1234]

They are on the classpath. If you comment one of the imports the parsing issue goes away.

Edited... You may be correct about the classpath. Let me try again in the demo project... I changed the import as it was an internal import.... I will update as with a better example. Though I am not sure how it would compile if not on the classpath.

The following compiles with no parsing issues so it is on the classpath I think.

package openrewrite.issues
import static org.mockito.Mockito.*
// import static org.mockito.Mockito.*
class DuplicateImport {

}

// Also note the following works.
package openrewrite.issues
import static org.mockito.Mockito.any
import static org.mockito.Mockito.any
class DuplicateImport {

}