Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support duplicate static star imports for Groovy #4982

Merged
merged 13 commits into from
Feb 5, 2025
Merged

Support duplicate static star imports for Groovy #4982

merged 13 commits into from
Feb 5, 2025

Conversation

jevanlingen
Copy link
Contributor

@jevanlingen jevanlingen commented Feb 3, 2025 •
edited
Loading

What's changed?

  • Duplicate static star imports work as well.
  • Shorten the parser code for ImportNode (we have now methods like sourceStartsWith)

What's your motivation?

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@jevanlingen jevanlingen linked an issue Feb 3, 2025 that may be closed by this pull request
Groovy parser fails when using duplicate static star imports #4068
Closed
@jevanlingen jevanlingen changed the title 4068-groovy-parser-fails-when-using-duplicate-static-star-imports Support duplicate static star imports for Groovy Feb 3, 2025
@jevanlingen jevanlingen self-assigned this Feb 3, 2025
@timtebeek timtebeek added parser-groovy bug Something isn't working labels Feb 3, 2025
Laurens-W
Laurens-W approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Laurens-W Laurens-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jevanlingen jevanlingen merged commit 4b21518 into main Feb 5, 2025
2 checks passed
@jevanlingen jevanlingen deleted the 4068-groovy-parser-fails-when-using-duplicate-static-star-imports branch February 5, 2025 07:30
@jevanlingen jevanlingen mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden knutwannheden left review comments

@Laurens-W Laurens-W Laurens-W approved these changes

@sambsnyd sambsnyd Awaiting requested review from sambsnyd

Assignees

@jevanlingen jevanlingen

Labels
bug Something isn't working parser-groovy
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Groovy parser fails when using duplicate static star imports
4 participants
@jevanlingen @knutwannheden @Laurens-W @timtebeek