Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve spacing when merging flow style YAML #4981

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BelmoMusta
Copy link

@BelmoMusta BelmoMusta commented Feb 1, 2025

What's changed?

Fixing the unwanted carriage return when merging yaml values that are written in flow style

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek changed the title fix(MergeYaml): preserve spacing when merging flow style YAML Preserve spacing when merging flow style YAML Feb 3, 2025
@timtebeek timtebeek added the bug Something isn't working label Feb 3, 2025
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @BelmoMusta ; should help improve the cases where folks use that flow style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready to Review
Development

Successfully merging this pull request may close these issues.

Style not preserved with MergeYaml when values are written in flow style
2 participants