SOFTWARE-6027: Use OSG 24 for default builds #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhlin
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Could you also update https://github.com/opensciencegrid/gratia-probe/blob/2.x/.github/workflows/build-sw-container.yml to push to hub.opensciencegrid.org/osg-htc? It's internal only so I'm fine with removing pushes to Docker Hub and the opensciencegrid project
One minor suggestion in-line
kubernetes/Dockerfile
Outdated
| ENV GRATIA_PROBE_VERSION=$TIMESTAMP_IMAGE | ||
| ARG UID=10000 | ||
| ARG GID=10000 | ||
|
|
||
| # Install EPEL, the OSG software base repo, and gratia-probe-common | ||
| RUN yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm && \ | ||
| yum install -y https://repo.opensciencegrid.org/osg/23-main/osg-23-main-el9-release-latest.rpm && \ | ||
| yum install -y https://repo.opensciencegrid.org/osg/$OSG_SERIES-main/osg-$OSG_SERIES-main-el9-release-latest.rpm && \ |
There was a problem hiding this comment.
Suggested change
| yum install -y https://repo.opensciencegrid.org/osg/$OSG_SERIES-main/osg-$OSG_SERIES-main-el9-release-latest.rpm && \ | |
| yum install -y https://repo.osg-htc.org/osg/$OSG_SERIES-main/osg-$OSG_SERIES-main-el9-release-latest.rpm && \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GHAs for this repo don't appear to use a build matrix for el/release version.