Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Koji from osg-internal-development in OSG series > 3.6 #173

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

matyasselmeci
Copy link
Contributor

No description provided.

@matyasselmeci matyasselmeci requested a review from a team as a code owner February 27, 2024 16:25
Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matyasselmeci
Copy link
Contributor Author

matyasselmeci commented Feb 27, 2024

Hm. The build results don't make sense. The matrix says "el7" but the "al8" image is getting pulled, and despite the --build-arg arg being right there, my if statement doesn't match.

EDIT: Because I hardcode the OS and I don't put the ARG back in scope after the FROM statement.

@matyasselmeci matyasselmeci merged commit 073ab6d into opensciencegrid:main Feb 27, 2024
9 checks passed
@matyasselmeci matyasselmeci deleted the koji-builder-osg23 branch February 27, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants