fixed an issue that the initial result summary generated with the wrong data #9611
+15
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps to reproduce:
Expected:
It should wait for the 2nd query to complete, then trigger the result summary.
This is a quick fix that stop loading discover results to summary component when natural language query is not provided(the initial case). Only when the query is generated with NLQ, the results will be loaded, and the summarization then will be triggered.
For the long term, the result summary component should not rely on the UI state of discover results. There will be a follow up PR to refactor the result summary component.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration