Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed an issue that the initial result summary generated with the wrong data #9611

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Mar 27, 2025

Description

Steps to reproduce:

  1. Open discover and let the default query(1st) to run
  2. After the results returned, use query assistant to generate a new ppl query(2nd)
  3. The result summary is immediately triggered automatically without waiting for the 2nd query to return
  4. The generated summary is incorrect because it uses the results of 1st query

Expected:

It should wait for the 2nd query to complete, then trigger the result summary.

This is a quick fix that stop loading discover results to summary component when natural language query is not provided(the initial case). Only when the query is generated with NLQ, the results will be loaded, and the summarization then will be triggered.

For the long term, the result summary component should not rely on the UI state of discover results. There will be a follow up PR to refactor the result summary component.

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.81%. Comparing base (4ef7f0b) to head (a623c2a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...c/query_assist/components/query_assist_summary.tsx 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9611      +/-   ##
==========================================
+ Coverage   61.79%   61.81%   +0.02%     
==========================================
  Files        3825     3825              
  Lines       92068    92072       +4     
  Branches    14604    14605       +1     
==========================================
+ Hits        56891    56918      +27     
+ Misses      31502    31475      -27     
- Partials     3675     3679       +4     
Flag Coverage Δ
Linux_1 28.94% <ø> (ø)
Linux_2 56.30% <ø> (ø)
Linux_3 39.42% <ø> (ø)
Linux_4 28.89% <80.00%> (+0.04%) ⬆️
Windows_1 28.96% <ø> (ø)
Windows_2 56.26% <ø> (ø)
Windows_3 39.43% <ø> (ø)
Windows_4 28.89% <80.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… data

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl ruanyl force-pushed the fix-discover-summary-initial-load-with-wrong-data branch from 42f660f to a623c2a Compare March 27, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant