[Backport 2.x] [Bugfix] Fix IllegalArgumentException thrown when creating a PIT #17380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteralfonsi
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gaobinlong,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
peternied,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
…nsearch-project#16781) * fix create_pit enum bug Signed-off-by: Peter Alfonsi <[email protected]> * changelog Signed-off-by: Peter Alfonsi <[email protected]> * Fix SearchResponse XContent Signed-off-by: Peter Alfonsi <[email protected]> * Addressed David's comments Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * Addressed andrross's comment Signed-off-by: Peter Alfonsi <[email protected]> * Revert "Addressed andrross's comment" This reverts commit 49fec57. Signed-off-by: Peter Alfonsi <[email protected]> * Revert "Addressed David's comments" This reverts commit a41f9be. Signed-off-by: Peter Alfonsi <[email protected]> * Revert "Fix SearchResponse XContent" This reverts commit ea30484. Signed-off-by: Peter Alfonsi <[email protected]> * Revert "fix create_pit enum bug" This reverts commit 0c9110d. Signed-off-by: Peter Alfonsi <[email protected]> * Fix create_pit bug with catch-all search phase name Signed-off-by: Peter Alfonsi <[email protected]> * switch to new optional method Signed-off-by: Peter Alfonsi <[email protected]> * rerun gradle Signed-off-by: Peter Alfonsi <[email protected]> * Update server/src/main/java/org/opensearch/action/search/SearchPhase.java Co-authored-by: Andrew Ross <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: Andrew Ross <[email protected]> (cherry picked from commit 56825f6) Signed-off-by: Peter Alfonsi <[email protected]>
peteralfonsi
force-pushed
the
backport-pit-to-2.x
branch
from
91cea12 to
b4ce8f1
Compare
|
❌ Gradle check result for b4ce8f1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #17380 +/- ##
============================================
+ Coverage 71.86% 72.04% +0.17%
- Complexity 65927 66001 +74
============================================
Files 5341 5341
Lines 307151 307186 +35
Branches 44825 44830 +5
============================================
+ Hits 220748 221315 +567
+ Misses 67976 67381 -595
- Partials 18427 18490 +63 ☔ View full report in Codecov by Sentry. |
|
Thanks @peteralfonsi , Hi @andrross shall we approve and merge this backport? Thanks! |
This was referenced Feb 18, 2025
andrross
approved these changes
Feb 18, 2025
Signed-off-by: Andrew Ross <[email protected]>
andrross
approved these changes
Feb 18, 2025
|
❕ Gradle check result for 6d12833: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #16781 to 2.x.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.