-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BC libraries to parse PEM files, increase key length, allow gener… #17393
base: main
Are you sure you want to change the base?
Use BC libraries to parse PEM files, increase key length, allow gener… #17393
Conversation
❌ Gradle check result for 62d1786: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
62d1786
to
99b1e83
Compare
❌ Gradle check result for 99b1e83: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
99b1e83
to
ac4fa36
Compare
❌ Gradle check result for ac4fa36: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ac4fa36
to
7a837ea
Compare
❌ Gradle check result for 7a837ea: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…al use of known cryptographic binary extensions, remove unused BC dependencies Signed-off-by: Iwan Igonin <[email protected]>
7a837ea
to
bd18542
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17393 +/- ##
============================================
- Coverage 72.38% 72.32% -0.06%
+ Complexity 65516 65480 -36
============================================
Files 5291 5291
Lines 304319 304065 -254
Branches 44176 44126 -50
============================================
- Hits 220269 219914 -355
- Misses 65964 66192 +228
+ Partials 18086 17959 -127 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for splitting up the PR @beanuwave. I think this is much easier to review at half the number of files for the first PR. @reta when you have some time could you also take a look?
NOTE: Basically a split up from the original PR
Description
This PR should provide a smoother transition to FIPS 140 standard by eliminating deprecated code, increase security standards and use more standardized approach to parse key files.
Reasons for refactoring PemUtils, which is used by the Reindex API in cases of migrating data from a remote cluster that is TLS protected:
Lack of support for evolving standards like PKCS#8.
Password-Based Key Derivation Functions such as PBKDF-OPENSSL are not supported in FIPS mode in favor of the PBKDF2 standard.
Java type safety.
It is generally a good idea to let ASN1 annotation parsing be done by external security libraries.
Related Issues
opensearch-project/security#3420
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.