Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pull-based Ingestion] Introduce ingestion management APIs #17631

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Pull-based Ingestion] Introduce ingestion management APIs #17631

wants to merge 4 commits into from
+3,264 −18

Conversation

varunbharadwaj
Copy link
Contributor

@varunbharadwaj varunbharadwaj commented Mar 19, 2025 •
edited
Loading

Description

This PR adds ingestion management APIs - mainly Pause, Resume and GetIngestionState APIs. This PR is a first version to introduce the APIs and subsequent PRs will build on this to support pagination and consumer reset options.

Related Issues

Part one of #17442

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for dcccf22: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Mar 19, 2025
Open
Closed
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 77aa63a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7402d31: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@varunbharadwaj varunbharadwaj force-pushed the vb/ingestionmgmt branch 2 times, most recently from b7617bf to 5756fd0 Compare March 21, 2025 23:24
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 5756fd0: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Mar 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.02098% with 263 lines in your changes missing coverage. Please review.

Project coverage is 72.33%. Comparing base (6d53f9d) to head (060d76c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...tadata/MetadataStreamingIngestionStateService.java 11.62% 38 Missing ⚠️
...ingestion/pause/TransportPauseIngestionAction.java 17.14% 29 Missing ⚠️
...gestion/resume/TransportResumeIngestionAction.java 17.14% 29 Missing ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 0.00% 18 Missing ⚠️
...reamingingestion/IngestionUpdateStateResponse.java 52.94% 16 Missing ⚠️
...streamingingestion/IngestionStateShardFailure.java 61.76% 13 Missing ⚠️
...mingingestion/state/GetIngestionStateResponse.java 43.47% 13 Missing ⚠️
.../streamingingestion/state/ShardIngestionState.java 72.50% 11 Missing ⚠️
...a/org/opensearch/index/engine/IngestionEngine.java 0.00% 10 Missing and 1 partial ⚠️
...ion/admin/indices/RestGetIngestionStateAction.java 23.07% 10 Missing ⚠️
... and 17 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #17631      +/-   ##
============================================
- Coverage     72.40%   72.33%   -0.07%     
- Complexity    65828    65851      +23     
============================================
  Files          5316     5339      +23     
  Lines        305294   305905     +611     
  Branches      44289    44338      +49     
============================================
+ Hits         221033   221266     +233     
- Misses        66187    66495     +308     
- Partials      18074    18144      +70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@varunbharadwaj varunbharadwaj changed the title [WIP] [Pull-based Ingestion] Introduce ingestion management APIs [Pull-based Ingestion] Introduce ingestion management APIs Mar 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 371e634: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7eccc3c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Mar 22, 2025
Open
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 060d76c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

yupeng9
yupeng9 reviewed Mar 22, 2025
View reviewed changes
Copy link
Contributor

@yupeng9 yupeng9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

@varunbharadwaj varunbharadwaj marked this pull request as ready for review March 22, 2025 18:35
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f41ccfa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for a6c5980: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c00230d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Mar 25, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for d1ec484: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross left review comments

@yupeng9 yupeng9 yupeng9 left review comments

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@bugmakerrrrrr bugmakerrrrrr Awaiting requested review from bugmakerrrrrr bugmakerrrrrr is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunbharadwaj @andrross @yupeng9