Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Add an AD transport client #1111

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Dec 6, 2023

Description

Backport of #1110.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler ohltyler marked this pull request as draft December 6, 2023 01:22
@ohltyler
Copy link
Member Author

ohltyler commented Dec 6, 2023

Converting to draft until #1110 merged

@ohltyler ohltyler changed the title [2.x] Add an AD client [2.x] Add an AD transport client Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #1111 (ea85bc2) into 2.x (558f556) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1111      +/-   ##
============================================
+ Coverage     79.64%   79.81%   +0.17%     
- Complexity     4336     4353      +17     
============================================
  Files           307      309       +2     
  Lines         18159    18176      +17     
  Branches       1909     1909              
============================================
+ Hits          14462    14507      +45     
+ Misses         2786     2763      -23     
+ Partials        911      906       -5     
Flag Coverage Δ
plugin 79.81% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...g/opensearch/ad/client/AnomalyDetectionClient.java 100.00% <100.00%> (ø)
...ensearch/ad/client/AnomalyDetectionNodeClient.java 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler ohltyler marked this pull request as ready for review December 12, 2023 16:33
@ohltyler ohltyler merged commit 2ea79db into opensearch-project:2.x Dec 12, 2023
18 of 19 checks passed
@ohltyler ohltyler deleted the ad-client branch December 12, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants