-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a feature that flattens custom result index when enabled #1401
base: main
Are you sure you want to change the base?
add a feature that flattens custom result index when enabled #1401
Conversation
Signed-off-by: Jackie Han <[email protected]>
dc1c604
to
9f0dcf6
Compare
Signed-off-by: Jackie Han <[email protected]>
d0d60f0
to
352075b
Compare
Signed-off-by: Jackie Han <[email protected]>
c947793
to
bf552b5
Compare
Signed-off-by: Jackie Han <[email protected]>
bf552b5
to
9fced72
Compare
resolved |
src/main/java/org/opensearch/ad/settings/AnomalyDetectorSettings.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/timeseries/indices/IndexManagement.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/transport/ADResultBulkTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/timeseries/rest/handler/AbstractTimeSeriesActionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/timeseries/rest/handler/AbstractTimeSeriesActionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/timeseries/indices/IndexManagement.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/timeseries/rest/handler/AbstractTimeSeriesActionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/timeseries/rest/handler/AbstractTimeSeriesActionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/timeseries/rest/handler/AbstractTimeSeriesActionHandler.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/ad/rest/AnomalyDetectorRestApiIT.java
Outdated
Show resolved
Hide resolved
2fd6bc2
to
8b12fd7
Compare
Signed-off-by: Jackie Han <[email protected]>
8b12fd7
to
3ce0734
Compare
Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
checking the failed bwc test... |
Signed-off-by: Jackie Han <[email protected]>
ac8f122
to
9ffc24f
Compare
src/main/java/org/opensearch/timeseries/rest/handler/AbstractTimeSeriesActionHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jackie Han <[email protected]>
4400f44
to
b876a22
Compare
Signed-off-by: Jackie Han <[email protected]>
f1e21cf
to
ad3d99c
Compare
Signed-off-by: Jackie Han <[email protected]>
ad3d99c
to
c844922
Compare
bwc test failure is similar to opensearch-project/OpenSearch#15234
|
@@ -1008,6 +1016,53 @@ public <T> void initCustomResultIndexAndExecute(String resultIndexOrAlias, Execu | |||
} | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you roll over flattened result index same as custom result index?
src/main/java/org/opensearch/timeseries/rest/handler/AbstractTimeSeriesActionHandler.java
Outdated
Show resolved
Hide resolved
@Override | ||
public void onResponse(AcknowledgedResponse acknowledgedResponse) { | ||
if (acknowledgedResponse.isAcknowledged()) { | ||
logger.info("Ingest pipeline deleted successfully for pipelineId: {}", pipelineId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not seem to return listener in this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do you need to remove the index.default_pipeline setting from the index?
src/main/java/org/opensearch/timeseries/rest/handler/AbstractTimeSeriesActionHandler.java
Outdated
Show resolved
Hide resolved
Map<String, Object> responseMap = entityAsMap(response); | ||
String id = (String) responseMap.get("_id"); | ||
List<Feature> features = detector.getFeatureAttributes(); | ||
long expectedFeatures = features.stream().filter(Feature::getEnabled).count(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do we check equality of expectedFeatures?
|
||
PutPipelineRequest putPipelineRequest = new PutPipelineRequest(pipelineId, pipelineSource, XContentType.JSON); | ||
|
||
client.admin().cluster().putPipeline(putPipelineRequest, ActionListener.wrap(response -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think use client.admin() is fine as I cannot find other ways of put pipeline with client and core's put pipeline api used the same thing: https://github.com/opensearch-project/OpenSearch/blob/32a88eb16bb7bff15fa5430c1490cd102c6cca28/server/src/main/java/org/opensearch/rest/action/ingest/RestPutPipelineAction.java#L77
Description
wip - sending implementation out first.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.