Update Kafka Buffer's auto_offset_reset default value #9167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Kafka Buffer's param `auto_offset_reset` default value. Same as for Kafka Source. Previous PR for Kafka Source: opensearch-project#9113 In code: https://github.com/opensearch-project/data-prepper/blob/main/data-prepper-plugins/kafka-plugins/src/main/java/org/opensearch/dataprepper/plugins/kafka/buffer/BufferTopicConfig.java#L33 Signed-off-by: Alexey Novopashin <[email protected]>
alexstrive
requested review from
kolchfa-aws,
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
Hello @kolchfa-aws |
kolchfa-aws
approved these changes
Feb 7, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
Update Kafka Buffer's param `auto_offset_reset` default value. Same as for Kafka Source. Previous PR for Kafka Source: #9113 In code: https://github.com/opensearch-project/data-prepper/blob/main/data-prepper-plugins/kafka-plugins/src/main/java/org/opensearch/dataprepper/plugins/kafka/buffer/BufferTopicConfig.java#L33 Signed-off-by: Alexey Novopashin <[email protected]> (cherry picked from commit 5454b79) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Update Kafka Buffer's param
auto_offset_resetdefault value in documentation. Same as for Kafka Source, 2 weeks ago.Previous PR for Kafka Source with the same correction: #9113
In code, Kafka Buffer's param
auto_offset_resetdefault value set toearliest:https://github.com/opensearch-project/data-prepper/blob/main/data-prepper-plugins/kafka-plugins/src/main/java/org/opensearch/dataprepper/plugins/kafka/buffer/BufferTopicConfig.java#L33
I decided to check Kafka sink plugin for the same problem, but didn't find such sink at documentation website. So, I've created issue #9166
Issues Resolved
None.
Version
List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.
DataPrepper documentation - all.
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Non-applicable.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.