Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo in Alias Message #1137

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

sarthakaggarwal97
Copy link
Contributor

Issue: #1123

Description of changes: Fixes a small type in the alias message

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.35%. Comparing base (a30e4b8) to head (d9db4ad).

❗ Current head d9db4ad differs from pull request most recent head 1bdb23c. Consider uploading reports for the commit 1bdb23c to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1137      +/-   ##
============================================
- Coverage     75.38%   75.35%   -0.03%     
+ Complexity     2813     2811       -2     
============================================
  Files           367      367              
  Lines         17038    17038              
  Branches       2370     2370              
============================================
- Hits          12844    12839       -5     
- Misses         2892     2896       +4     
- Partials       1302     1303       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@r1walz r1walz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ty.

Signed-off-by: Sarthak Aggarwal <[email protected]>
@r1walz r1walz merged commit b80e372 into opensearch-project:main Mar 19, 2024
26 of 29 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1137-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b80e37214dfcd692bcfcf5dda291d7c4098c0bc2
# Push it to GitHub
git push --set-upstream origin backport/backport-1137-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1137-to-2.x.

@r1walz
Copy link
Collaborator

r1walz commented Mar 19, 2024

Hi, @sarthakaggarwal97. Thanks for contributing. Would love to see it get backported to 2.x as well. Can you take it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants