-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Typo in Alias Message #1137
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1137 +/- ##
============================================
- Coverage 75.38% 75.35% -0.03%
+ Complexity 2813 2811 -2
============================================
Files 367 367
Lines 17038 17038
Branches 2370 2370
============================================
- Hits 12844 12839 -5
- Misses 2892 2896 +4
- Partials 1302 1303 +1 ☔ View full report in Codecov by Sentry. |
85976f9
to
e20b5fc
Compare
...lin/org/opensearch/indexmanagement/indexstatemanagement/step/rollover/AttemptRolloverStep.kt
Outdated
Show resolved
Hide resolved
e20b5fc
to
d9db4ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. ty.
Signed-off-by: Sarthak Aggarwal <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1137-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b80e37214dfcd692bcfcf5dda291d7c4098c0bc2
# Push it to GitHub
git push --set-upstream origin backport/backport-1137-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.x Then, create a pull request where the |
Hi, @sarthakaggarwal97. Thanks for contributing. Would love to see it get backported to 2.x as well. Can you take it up? |
Issue: #1123
Description of changes: Fixes a small type in the alias message
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.