start_time npe fix for Rollup and Transform jobs #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecified explicitly assign current time to start_time Signed-off-by: Oleg Kravchuk <[email protected]>
ikibo
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep,
AWSHurneyt,
jowg-amazon,
r1walz and
vikasvb90
as code owners
ikibo
changed the title
bowenlan-amzn
previously approved these changes
May 1, 2024
Signed-off-by: Oleg Kravchuk <[email protected]>
bowenlan-amzn
approved these changes
May 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
(cherry picked from commit ffabd86) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if start_time not pecified explicitly assign current time to start_time
Issue #1161
Description of changes:
if start_time not pecified explicitly assign current time to start_time to prevent the NPE and avoid a braking change
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.