bump com.pinterest.ktlint:ktlint-cli from 1.1.0 to 1.5.0 and appease ktlint #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivansh Arora <[email protected]>
shiv0408
requested review from
bowenlan-amzn,
Hailong-am,
vikasvb90,
tandonks and
soosinha
as code owners
Signed-off-by: Shivansh Arora <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1336-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f8889e6a2517545dbd6c5b4130f79a7e14cc554b
# Push it to GitHub
git push --set-upstream origin backport/backport-1336-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.xThen, create a pull request where the |
shiv0408
added a commit
to shiv0408/index-management
that referenced
this pull request
Jan 14, 2025
Signed-off-by: Shivansh Arora <[email protected]>
shiv0408
added a commit
that referenced
this pull request
Jan 19, 2025
* bump ktlint from 1.1.0 to 1.5.0 (#1336) Signed-off-by: Shivansh Arora <[email protected]> * appease ktlint Signed-off-by: Shivansh Arora <[email protected]> . Signed-off-by: Shivansh Arora <[email protected]> --------- Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps com.pinterest.ktlint:ktlint-cli from 1.1.0 to 1.5.0.
Build was failing in #1317 because of newly introduced rules between this upgrade. Ran
ktlint --formatto apply these rules.Suppresses backing property naming in IndexUtil.kt and RestHandlerUtil.kt files as this will require renaming the constant variable names and usage across files. Suppressing them in these files so that these rules are being followed following merge of this PR.