[Backport main] Add new test suite and workflow for left navigation menu #1710
+377
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Wang <[email protected]>
Signed-off-by: Owen Wang <[email protected]>
Signed-off-by: Owen Wang <[email protected]>
Signed-off-by: Owen Wang <[email protected]>
…search-project#1707) * Add new test suite and workflow for left navigation menu Signed-off-by: Owen Wang <[email protected]> * Fix missing config for disable workspace Signed-off-by: Owen Wang <[email protected]> * Address comments by adding additional assertion to navigation menu Signed-off-by: Owen Wang <[email protected]> * Fix lint issue in dashboards test cases Signed-off-by: Owen Wang <[email protected]> --------- Signed-off-by: Owen Wang <[email protected]> (cherry picked from commit 947aaa0)
FriedhelmWS
changed the title
FriedhelmWS
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu,
yujin-emma and
yubonluo
as code owners
SuZhou-Joe
approved these changes
Feb 17, 2025
raintygao
approved these changes
Feb 17, 2025
wanglam
reviewed
Feb 17, 2025
| @@ -6,6 +6,10 @@ | |||
| /// <reference types="cypress" /> | |||
|
|
|||
| import { setTimeFilter, TRACE_ID } from '../../../utils/constants'; | |||
| import customParseFormat from 'dayjs/plugin/customParseFormat'; | |||
| import dayjs from 'dayjs'; | |||
There was a problem hiding this comment.
Do we need to backport all the changes in this file? Seems dayjs not been used in test cases below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually backport 947aaa0 from #1707
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.