-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended /certificates endpoint with additional SSL certs info #4882
Open
willyborankin
wants to merge
1
commit into
opensearch-project:main
Choose a base branch
from
willyborankin:ssl-endpoint-additonal-info
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extended /certificates endpoint with additional SSL certs info #4882
willyborankin
wants to merge
1
commit into
opensearch-project:main
from
willyborankin:ssl-endpoint-additonal-info
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
requested review from
cwperks,
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997 and
reta
as code owners
November 7, 2024 16:55
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4882 +/- ##
==========================================
+ Coverage 71.41% 71.49% +0.07%
==========================================
Files 334 333 -1
Lines 22515 22533 +18
Branches 3585 3580 -5
==========================================
+ Hits 16080 16110 +30
+ Misses 4643 4632 -11
+ Partials 1792 1791 -1
|
cwperks
reviewed
Nov 11, 2024
src/main/java/org/opensearch/security/dlic/rest/api/ssl/CertificateType.java
Show resolved
Hide resolved
cwperks
reviewed
Nov 11, 2024
src/main/java/org/opensearch/security/dlic/rest/api/ssl/CertificateInfo.java
Outdated
Show resolved
Hide resolved
willyborankin
force-pushed
the
ssl-endpoint-additonal-info
branch
from
November 12, 2024 17:43
bab21d1
to
babe0dc
Compare
Enhanced the /certificates endpoint to provide more detailed information. The endpoint now lists all certificates used by each node, with additional properties for each certificate, including: - "format" - "alias" - "serial_number" - "has_private_key" Signed-off-by: Andrey Pleskach <[email protected]>
willyborankin
force-pushed
the
ssl-endpoint-additonal-info
branch
from
November 14, 2024 16:40
babe0dc
to
a9d34d4
Compare
cwperks
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhanced the
/certificates
endpoint to provide more detailed information. The endpoint now lists all certificates used by each node, with additional properties for each certificate, including:format
alias
serial_number
has_private_key
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.