-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Health Status of security-auditlog Index in Single Node Clusters #5030
Merged
cwperks
merged 8 commits into
opensearch-project:main
from
Ganesh-RB:auditlog_index_health_single_node_case
Feb 4, 2025
Merged
Improve Health Status of security-auditlog Index in Single Node Clusters #5030
cwperks
merged 8 commits into
opensearch-project:main
from
Ganesh-RB:auditlog_index_health_single_node_case
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Bombatkar <[email protected]>
Ganesh-RB
requested review from
cwperks,
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
January 15, 2025 09:56
shikharj05
reviewed
Jan 15, 2025
src/main/java/org/opensearch/security/auditlog/sink/AbstractInternalOpenSearchSink.java
Outdated
Show resolved
Hide resolved
shikharj05
reviewed
Jan 15, 2025
src/main/java/org/opensearch/security/auditlog/sink/AbstractInternalOpenSearchSink.java
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Jan 16, 2025
src/main/java/org/opensearch/security/auditlog/sink/AbstractInternalOpenSearchSink.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ganesh Bombatkar <[email protected]>
Ganesh-RB
force-pushed
the
auditlog_index_health_single_node_case
branch
from
January 23, 2025 19:32
7d60d06
to
0bceb07
Compare
shikharj05
reviewed
Jan 24, 2025
src/main/java/org/opensearch/security/auditlog/sink/AbstractInternalOpenSearchSink.java
Outdated
Show resolved
Hide resolved
shikharj05
reviewed
Jan 24, 2025
src/main/java/org/opensearch/security/auditlog/sink/AbstractInternalOpenSearchSink.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ganesh Bombatkar <[email protected]>
shikharj05
approved these changes
Jan 24, 2025
src/main/java/org/opensearch/security/auditlog/sink/AbstractInternalOpenSearchSink.java
Outdated
Show resolved
Hide resolved
shikharj05
reviewed
Jan 24, 2025
src/main/java/org/opensearch/security/auditlog/sink/AbstractInternalOpenSearchSink.java
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Jan 24, 2025
src/main/java/org/opensearch/security/auditlog/sink/AbstractInternalOpenSearchSink.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
…on before actual test Signed-off-by: Ganesh Bombatkar <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5030 +/- ##
==========================================
- Coverage 71.50% 71.49% -0.01%
==========================================
Files 336 336
Lines 22625 22643 +18
Branches 3598 3602 +4
==========================================
+ Hits 16178 16189 +11
- Misses 4648 4651 +3
- Partials 1799 1803 +4
|
cwperks
approved these changes
Feb 3, 2025
RyanL1997
approved these changes
Feb 4, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
…ers (#5030) Signed-off-by: Ganesh Bombatkar <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Ganesh Bombatkar <[email protected]> Co-authored-by: Craig Perkins <[email protected]> (cherry picked from commit dbfecca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug Fix: Improve Health Status of security-auditlog Index in Single Node Clusters
This pull request addresses an issue where the
security-auditlog
index was showing a yellow health status in single node clusters. The problem was caused by the use ofindexrequest
default settings, which were not optimal for single node environments.Changes:
security-auditlog
index to:Issues Resolved
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.