[WIP] FEAT(#3038): iplocation command #3085
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenrickyap
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin and
noCharger
as code owners
jduo
reviewed
Oct 18, 2024
core/build.gradle
Outdated
| @@ -46,6 +46,8 @@ pitest { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation "org.opensearch:opensearch-geospatial-spi:${opensearch_build}" | |||
There was a problem hiding this comment.
I don't see why core needs to depend on geospatial.
kenrickyap
changed the title
This reverts commit 55e899d.
jduo
reviewed
Oct 23, 2024
| public GeoipExpression(Expression datasource, Expression ipAddress, String properties) { | ||
| this.datasource = datasource; | ||
| this.ipAddress = ipAddress; | ||
| this.properties = properties.split(","); |
There was a problem hiding this comment.
You probably want the parser to do this for you rather than splitting manually during logical planning.
kenrickyap
changed the title
| import org.opensearch.sql.ast.expression.When; | ||
| import org.opensearch.sql.ast.expression.WindowFunction; | ||
| import org.opensearch.sql.ast.expression.Xor; | ||
| import org.opensearch.sql.ast.expression.*; |
There was a problem hiding this comment.
Avoid using * imports.
| import org.opensearch.sql.ast.expression.When; | ||
| import org.opensearch.sql.ast.expression.WindowFunction; | ||
| import org.opensearch.sql.ast.expression.Xor; | ||
| import org.opensearch.sql.ast.expression.*; |
There was a problem hiding this comment.
Avoid using * imports. May need to change your IDE configuration.
| import org.opensearch.sql.ast.expression.When; | ||
| import org.opensearch.sql.ast.expression.WindowFunction; | ||
| import org.opensearch.sql.ast.expression.Xor; | ||
| import org.opensearch.sql.ast.expression.*; |
There was a problem hiding this comment.
Avoid using * imports.
| import java.util.stream.Collectors; | ||
|
|
||
| /** | ||
| * Expression node of scalar function. Params include function name (@funcName) and function |
There was a problem hiding this comment.
I don't understand this Javadoc comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #3038
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.