Add OpenSergoClientManager to support client reuse #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiangnan Jia <[email protected]>
sczyh30
reviewed
Feb 7, 2023
| * @param config OpenSergoConfig | ||
| * @return OpenSergoClient | ||
| */ | ||
| public OpenSergoClient getOrCreateClient(String host, int port, OpenSergoConfig config) { |
There was a problem hiding this comment.
Pay attention to thread-safety here.
| return this; | ||
| } | ||
|
|
||
| public OpenSergoClient.Builder openSergoConfig(OpenSergoConfig openSergoConfig) { |
There was a problem hiding this comment.
后面我们需要优化 builder 里面的元素，是不是可以把 OpenSergoConfig 里面的配置平铺到 builder 里面处理，让用户更易用？
There was a problem hiding this comment.
是把 OpenSergoConfig 取消掉吗？
sczyh30
approved these changes
Feb 7, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiangnan Jia [email protected]
Describe what this PR does / why we need it
support client reuse
Does this pull request fix one issue?
Fixes #8
Describe how you did it
OpenSergoClientManagerto manage the reuse OpenSergoClientBuilderin OpenSergoClient for creating instanceOpenSergoConfigto support customized configDescribe how to verify it
Special notes for reviews