Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for transport procedure #28

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Add unit tests for transport procedure #28

merged 3 commits into from
Mar 14, 2023

Conversation

Jax4Li
Copy link
Contributor

@Jax4Li Jax4Li commented Mar 11, 2023

Describe what this PR does / why we need it

Add unit tests for transport procedure.

  1. Client and Server transport procedure.
  2. Observer mechanism
  3. Data cache and version mechanism

Does this pull request fix one issue?

Issues #13

Describe how you did it

Create fake some service implements in test cases, they can client.

Describe how to verify it

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sczyh30 sczyh30 added the area/test Issues or PRs related to test label Mar 11, 2023
@sczyh30 sczyh30 requested review from sczyh30 and jnan806 March 11, 2023 10:17
@jnan806
Copy link
Collaborator

jnan806 commented Mar 13, 2023

@Jax4Li Could you please add some short comments at the @Test function ~

@Jax4Li
Copy link
Contributor Author

Jax4Li commented Mar 13, 2023 •
edited
Loading

@Jax4Li Could you please add some short comments at the @Test function ~

sure

@jnan806
Copy link
Collaborator

jnan806 commented Mar 13, 2023 •
edited
Loading

The scope definition of OpenSergoClientTest.java is too large for your test cases, maybe OpenSergoSubscribeConfigTest.java or OpenSergoUniversalTransportServiceTest.java maybe is more suitable. 😃

@Jax4Li
Copy link
Contributor Author

Jax4Li commented Mar 13, 2023

The scope definition of OpenSergoClientTest.java is too large for your test cases, maybe OpenSergoSubscribeConfigTest.java or OpenSergoUniversalTransportServiceTest.java maybe is more suitable. 😃

Yeah, OpenSergoUniversalTransportServiceTest.java is ok,

jnan806
jnan806 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@jnan806 jnan806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM， thanks !

@jnan806
Copy link
Collaborator

jnan806 commented Mar 14, 2023 •
edited
Loading

cc @sczyh30 any other questions ?

sczyh30
sczyh30 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 35f33be into opensergo:main Mar 14, 2023
@sczyh30
Copy link
Member

sczyh30 commented Mar 14, 2023

Nice work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnan806 jnan806 jnan806 approved these changes

@sczyh30 sczyh30 sczyh30 approved these changes

Assignees
No one assigned
Labels
area/test Issues or PRs related to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jax4Li @CLAassistant @jnan806 @sczyh30