Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration support for OpenSergoClient #22 #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jax4Li
Copy link
Contributor

@Jax4Li Jax4Li commented Mar 25, 2023

Describe what this PR does / why we need it

Add configuration support for OpenSergoClient, include tls、keepalive time、retry.

Does this pull request fix one issue?

issues#22

Describe how you did it

build OpenSergoClient config by builder with some default value.

Describe how to verify it

Special notes for reviews

Copy link
Collaborator

@jnan806 jnan806 Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jax4Li @sczyh30
I have a question that, need we to separate the network-communication-config and OpenSergo-self-config in OpenSergoClientConfig with MemberClasses.


是否需要在 OpenSergoClientConfig 中定义内部类来区分 网络通讯框架的 config 和 OpenSergo 自身的 config。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能是有必要的,会不会存在这样的情况OpenSergoClientConfig除了包含网络通讯框架的 config 还会有其他的?你们觉得呢

@jnan806 jnan806 added the area/configuration Issue related to configurations of OpenSergo SDK label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration Issue related to configurations of OpenSergo SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants