Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-971: Add Agent-Based installer support for iSCSI #1727

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bfournie
Copy link
Contributor

@bfournie bfournie commented Dec 21, 2024

Add support for booting off iSCSI. A new boot mode - ISCSI, is added and is used to boot both the agent ISO and the installed image.

In order to boot the final image using ISCSI the rootDeviceHint has been added to agent-config.yaml.

Requires openshift/installer#9356.

Note that iSCSI is only supported for dhcp since coreos-installer does not support --copy-network when using the ISCSI network, see coreos/coreos-installer#1389.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2024
Copy link

openshift-ci bot commented Dec 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bfournie. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add support for booting off iSCSI. A new boot mode - ISCSI, is
added and is used to boot both the agent ISO and the installed image.
@bfournie bfournie changed the title [WIP] AGENT-971: Add Agent-Based installer support for iSCSI AGENT-971: Add Agent-Based installer support for iSCSI Jan 3, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2025
@bfournie
Copy link
Contributor Author

bfournie commented Jan 3, 2025

/cc @rwsu @andfasano

@openshift-ci openshift-ci bot requested review from andfasano and rwsu January 3, 2025 17:31
@bfournie
Copy link
Contributor Author

bfournie commented Jan 3, 2025

/uncc @dtantsur

@openshift-ci openshift-ci bot removed the request for review from dtantsur January 3, 2025 17:31
@bfournie
Copy link
Contributor Author

bfournie commented Jan 3, 2025

/cc @adriengentil

Copy link

openshift-ci bot commented Jan 3, 2025

@bfournie: GitHub didn't allow me to request PR reviews from the following users: adriengentil.

Note that only openshift-metal3 members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @adriengentil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bfournie
Copy link
Contributor Author

bfournie commented Jan 7, 2025

Confirmed successful SNO installation using following settings:

export AGENT_E2E_TEST_BOOT_MODE=ISCSI
export OPENSHIFT_RELEASE_STREAM=4.18
export AGENT_NMSTATE_DHCP=true
export AGENT_MINIMAL_ISO=true
export AGENT_E2E_TEST_SCENARIO=SNO_IPV4_DHCP

@bfournie
Copy link
Contributor Author

/test e2e-agent-compact-ipv4

@bfournie
Copy link
Contributor Author

bfournie commented Jan 10, 2025

Confirmed successful multi-node installation using following settings:

export AGENT_E2E_TEST_BOOT_MODE=ISCSI
export OPENSHIFT_RELEASE_STREAM=4.18
export AGENT_MINIMAL_ISO=true
export AGENT_E2E_TEST_SCENARIO=COMPACT_IPV4_DHCP

Note that openshift/installer#9356 is required.

Results of testing with iSCSI:

$ oc get nodes
NAME       STATUS   ROLES                         AGE   VERSION
master-0   Ready    control-plane,master,worker   52m   v1.31.3
master-1   Ready    control-plane,master,worker   68m   v1.31.3
master-2   Ready    control-plane,master,worker   68m   v1.31.3

[core@master-0 ~]$ lsblk -S
NAME HCTL       TYPE VENDOR   MODEL          REV SERIAL                               TRAN
sda  0:0:0:0    disk QEMU     QEMU HARDDISK 2.5+ drive-scsi0-0-0-0                    
sdb  7:0:0:0    disk LIO-ORG  master-0      4.0  4972e62f-1081-4fae-a3f7-d93493639829 iscsi
sr0  2:0:0:0    rom  QEMU     QEMU DVD-ROM  2.5+ QM00003                              sata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants