Add ARO HCP v1alpha1 root resource #1016
Merged
+65,996
−6,762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimrodshn
force-pushed
the
add_aro_hcp_v1_alpha1_service
branch
11 times, most recently
from
c8d0aa7 to
09f1ce0
Compare
zgalor
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Version bump missing here
https://github.com/openshift-online/ocm-sdk-go/blob/main/version.go#L21
nimrodshn
force-pushed
the
add_aro_hcp_v1_alpha1_service
branch
from
09f1ce0 to
09427ae
Compare
|
LGTM 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
@refstatement.