Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foo is bar #304

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Foo is bar #304

merged 2 commits into from
Feb 5, 2025

Conversation

vdemeester
Copy link
Member

Signed-off-by: Vincent Demeester [email protected]

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester
Copy link
Member Author

/help

Copy link

🤖 Available Commands

Command Description
/assign user1 user2 Assigns users for review to the PR
/unassign user1 user2 Removes assigned users
/label bug feature Adds labels to the PR
/unlabel bug feature Removes labels from the PR
/lgtm Approves the PR if at least 2 org members have commented /lgtm
/help Shows this help message

@vdemeester
Copy link
Member Author

/label bug

@red-hat-konflux red-hat-konflux bot added the bug Something isn't working label Feb 3, 2025
@vdemeester
Copy link
Member Author

~ λ tkn pr logs -f prow-commands-hgl8f
[manage-pr : manage-pr] Not enough valid /lgtm votes (found 1, need 2).

@vdemeester
Copy link
Member Author

/assign @lcarva

@lcarva
Copy link

lcarva commented Feb 3, 2025

/lgtm

@vdemeester
Copy link
Member Author

/help

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester
Copy link
Member Author

/help

Copy link

🤖 Available Commands

Command Description
/assign user1 user2 Assigns users for review to the PR
/unassign user1 user2 Removes assigned users
/label bug feature Adds labels to the PR
/unlabel bug feature Removes labels from the PR
/lgtm Approves the PR if at least 1 org members have commented /lgtm
/merge Merges the PR if it has enough /lgtm approvals
/help Shows this help message

@vdemeester
Copy link
Member Author

/merge

Copy link

⚠️ Invalid LGTM Vote

  • User @vdemeester attempted to approve their own PR
  • Self-approval is not permitted for security reasons
  • Please delete the comment before continuing.

Please wait for reviews from other team members.

@savitaashture
Copy link
Member

/lgtm

Copy link

⚠️ Invalid LGTM Vote

  • User @vdemeester attempted to approve their own PR
  • Self-approval is not permitted for security reasons
  • Please delete the comment before continuing.

Please wait for reviews from other team members.

@vdemeester
Copy link
Member Author

/merge

Copy link

LGTM Vote Breakdown

  • Current valid votes: 1/1
  • Voting required for approval: 1

Votes Summary:

Reviewer Permission Valid Vote
@lcarva read
@savitaashture admin

Copy link

@red-hat-konflux red-hat-konflux bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Pull Request Approved

Approval Status:

  • Required Approvals: 1
  • Current Approvals: 1

👥 Approved By:

Reviewer Permission Status
@lcarva read
@savitaashture admin

📝 Next Steps

  • All required checks must pass
  • Branch protection rules apply
  • Get a maintainer to use the /merge command to merge the PR

Thank you for your contributions! 🎉

@red-hat-konflux red-hat-konflux bot merged commit 835bba8 into main Feb 5, 2025
1 check passed
Copy link

✅ PR Successfully Merged

  • Merge method: rebase
  • Merged by: @vdemeester
  • Total approvals: 1/1

Approvals Summary:

Reviewer Permission Status
@lcarva read
@savitaashture admin

@red-hat-konflux red-hat-konflux bot deleted the testing-something branch February 5, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants