Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPQE-18643: Add python3 deps required to run pruning #44

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

jadhaj
Copy link
Contributor

@jadhaj jadhaj commented Jan 4, 2024

The PR addresses jira ticket https://issues.redhat.com/browse/OCPQE-18643

@openshift-ci openshift-ci bot requested review from aleskandro and jhou1 January 4, 2024 08:30
@aleskandro aleskandro changed the title Add python3 deps required to run pruning OCPQE-18643: Add python3 deps required to run pruning Jan 8, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 8, 2024

@jadhaj: This pull request references OCPQE-18643 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

The PR addresses jira ticket https://issues.redhat.com/browse/OCPQE-18643

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jadhaj
Copy link
Contributor Author

jadhaj commented Jan 17, 2024

@aleskandro ci/prow/shellcheck failed and complaining about X prefix
i did not complain about before:

Avoid x-prefix in comparisons as it no longer serves a purpose.
Did you mean:
echo "Require $N_MASTERS masters and $N_WORKERS workers $([ "$REQUEST_BOOTSTRAP_HOST" == "true" ] && echo -n '(+ 1 bootstrap node)') = $NUM_HOSTS hosts"

should I follow their advice?

@aleskandro
Copy link
Member

Hi @jadhaj , can you rebase to doublecheck shellcheck? You shouldn't care about a script you didn't modify.

@jadhaj
Copy link
Contributor Author

jadhaj commented Jan 17, 2024

Hi @jadhaj , can you rebase to doublecheck shellcheck? You shouldn't care about a script you didn't modify.

shellcheck passed after rebase

@aleskandro
Copy link
Member

Great, can you squash the commits into one and test on arm too?

@jadhaj
Copy link
Contributor Author

jadhaj commented Jan 18, 2024

@aleskandro
Copy link
Member

/lgtm
/approve

Thanks Jad!

Copy link

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro, jadhaj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d282a74 into openshift-qe:master Jan 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants