-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPQE-18643: Add python3 deps required to run pruning #44
Conversation
@jadhaj: This pull request references OCPQE-18643 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@aleskandro ci/prow/shellcheck failed and complaining about X prefix Avoid x-prefix in comparisons as it no longer serves a purpose. should I follow their advice? |
Hi @jadhaj , can you rebase to doublecheck shellcheck? You shouldn't care about a script you didn't modify. |
shellcheck passed after rebase |
Great, can you squash the commits into one and test on arm too? |
/lgtm Thanks Jad! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleskandro, jadhaj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The PR addresses jira ticket https://issues.redhat.com/browse/OCPQE-18643