Skip to content

OPRUN-3766: Add FeatureFlag for OLMv1 Single/OwnNamespace #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OPRUN-3766: Add FeatureFlag for OLMv1 Single/OwnNamespace #2264

wants to merge 1 commit into from
+27 −0

Conversation

perdasilva
Copy link

Adds the 'NewOLMOwnSingleNamespace' cluster capability.

Clones #2258

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2025 •
edited by openshift-ci bot
Loading

@perdasilva: This pull request references OPRUN-3766 which is a valid jira issue.

In response to this:

Adds the 'NewOLMOwnSingleNamespace' cluster capability.

Clones #2258

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 7, 2025

Hello @perdasilva! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@perdasilva perdasilva mentioned this pull request Apr 7, 2025
Closed
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 7, 2025
@openshift-ci openshift-ci bot requested review from deads2k and everettraven April 7, 2025 16:42
@perdasilva
Copy link
Author

/retest

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 8, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 00e6260 and 2 for PR HEAD e7a5fe5 in total

@perdasilva perdasilva force-pushed the newolmownsinglenamespace-updated branch from e7a5fe5 to b3bce9c Compare April 8, 2025 18:31
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2025
@perdasilva perdasilva force-pushed the newolmownsinglenamespace-updated branch from b3bce9c to c66b807 Compare April 8, 2025 18:36
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2025
@perdasilva perdasilva force-pushed the newolmownsinglenamespace-updated branch from c66b807 to 4ec85f1 Compare April 8, 2025 18:40
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2025
@tmshort
Copy link
Contributor

tmshort commented Apr 8, 2025

Why is the diff for features.go so large? Looks as though the formatting was changed inadvertently?

@perdasilva perdasilva force-pushed the newolmownsinglenamespace-updated branch 2 times, most recently from 7cc76ac to 3c82736 Compare April 9, 2025 11:48
@thetechnick
Add FeatureFlag for OLMv1 Single/OwnNamespace
869bf7a 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the newolmownsinglenamespace-updated branch from 3c82736 to 869bf7a Compare April 9, 2025 11:50
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 9, 2025
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@tmshort
Copy link
Contributor

tmshort commented Apr 14, 2025

/retest-required

2 similar comments
@thetechnick
Copy link

/retest-required

@thetechnick
Copy link

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 869bf7a in total

@tmshort
Copy link
Contributor

tmshort commented Apr 15, 2025

/test e2e-aws-serial-techpreview

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 869bf7a in total

@thetechnick
Copy link

/test e2e-aws-serial-techpreview

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 869bf7a in total

@tmshort
Copy link
Contributor

tmshort commented Apr 16, 2025

/retest-required

@jianzhangbjz
Copy link

I checked https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2264/pull-ci-openshift-api-master-e2e-aws-serial-techpreview/1912578540054777856, found

[OLM][invariant] alert/KubePodNotReady should not be at or above pending in ns/openshift-marketplace 
...
{  KubePodNotReady was at or above pending for at least 9m40s on platformidentification.JobType{Release:"4.19", FromRelease:"", Platform:"aws", Architecture:"amd64", Network:"ovn", Topology:"ha"} (maxAllowed=0s): pending for 9m40s, firing for 0s:

Apr 16 19:47:07.724 - 58s   I namespace/openshift-marketplace pod/certified-operators-psvl5 alert/KubePodNotReady alertstate/pending severity/warning ALERTS{alertname="KubePodNotReady", alertstate="pending", namespace="openshift-marketplace", pod="certified-operators-psvl5", prometheus="openshift-monitoring/k8s", severity="warning"}
...

However, I checked the must-gather log, the catalogsource pods worked well.

jiazha-mac:~ jiazha$ omc use Downloads/must-gather-api
Must-Gather    : /Users/jiazha/Downloads/must-gather-api/registry-build07-ci-openshift-org-ci-op-z2mn6bpq-stable-sha256-181f508aee13e814674994d2d90e5463b393049ca6400eae4ccfbb20b82a8046
Project        : default
ApiServerURL   : https://api.ci-op-z2mn6bpq-d6dbc.origin-ci-int-aws.dev.rhcloud.com:6443
Platform       : AWS
ClusterID      : da9a62b5-1703-4824-a306-bbad2514d588
ClusterVersion : 4.19.0-0.ci-2025-04-16-185545-test-ci-op-z2mn6bpq-latest
ClientVersion  : v4.2.0-alpha.0-2640-gbeeaf09
Image          : registry-build07-ci-openshift-org-ci-op-z2mn6bpq-stable
jiazha-mac:~ jiazha$ 
jiazha-mac:~ jiazha$ omc get pods -n openshift-marketplace
NAME                                   READY   STATUS    RESTARTS   AGE
certified-operators-szcrv              1/1     Running   0          4m
community-operators-p5lg5              1/1     Running   0          3h
marketplace-operator-8bd784f8b-tb7rp   1/1     Running   0          3h
redhat-marketplace-2vfbz               1/1     Running   0          3h
redhat-operators-ls8jn                 1/1     Running   0          9m

Hi @JoelSpeed , could you help force merge it? Thanks! cc: @joelanford @thetechnick

@jianzhangbjz
Copy link

/test e2e-aws-serial-techpreview

1 similar comment
@jianzhangbjz
Copy link

/test e2e-aws-serial-techpreview

@JoelSpeed
Copy link
Contributor

Given the proximity to branching, and the fact that we are only adding a new gate here, it's fair to say this feature is not going to be in 4.19.

I wonder if it would be pertinent to delay merging this now until after branching? Else we will have a gate with absolutely no code behind it?

@jianzhangbjz
Copy link

Reply it on Slack https://redhat-internal.slack.com/archives/CE4L0F143/p1744880536909679?thread_ts=1744879154.615619&cid=CE4L0F143

@grokspawn
Copy link
Contributor

/test e2e-aws-serial-techpreview

@grokspawn grokspawn mentioned this pull request Apr 17, 2025
Open
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 869bf7a in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 869bf7a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 869bf7a in total

@tmshort
Copy link
Contributor

tmshort commented Apr 18, 2025

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f636181 and 1 for PR HEAD 869bf7a in total

@tmshort
Copy link
Contributor

tmshort commented Apr 18, 2025

/retest-required

@jianzhangbjz
Copy link

/test e2e-aws-serial-techpreview

@grokspawn
Copy link
Contributor

/retest-required

@jianzhangbjz
Copy link

/test e2e-aws-serial-techpreview

@jianzhangbjz
Copy link

/retest-required

3 similar comments
@tmshort
Copy link
Contributor

tmshort commented Apr 21, 2025

/retest-required

@grokspawn
Copy link
Contributor

/retest-required

@jianzhangbjz
Copy link

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@perdasilva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview 869bf7a link true /test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@everettraven everettraven Awaiting requested review from everettraven

Assignees

@JoelSpeed JoelSpeed

@tmshort tmshort

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@perdasilva @openshift-ci-robot @JoelSpeed @tmshort @grokspawn @thetechnick @jianzhangbjz @openshift-merge-robot