Skip to content

features: remove ShortCertRotation from DevPreviewNoUpgrade #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

features: remove ShortCertRotation from DevPreviewNoUpgrade #2270

wants to merge 1 commit into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Apr 10, 2025 •
edited
Loading

This featuregate needs to be enabled separately via CustomNoUpgrade
featureset

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

Hello @vrutkovs! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 10, 2025
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed April 10, 2025 15:28
@vrutkovs vrutkovs force-pushed the short-cert-rotation-move-from-dev branch from 53ea91e to 9ade559 Compare April 10, 2025 15:33
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2025
@vrutkovs vrutkovs changed the title Update ShortCertRotation: remove it from DevPreviewNoUpgrade features: remove ShortCertRotation from DevPreviewNoUpgrade Apr 10, 2025
@vrutkovs
Remove ShortCertRotation from devpreview featureset
0be88df 
This featuregate needs to be enabled separately via CustomNoUpgrade
featureset
@vrutkovs vrutkovs force-pushed the short-cert-rotation-move-from-dev branch from 9ade559 to 0be88df Compare April 10, 2025 15:44
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2025
@sjenning
Copy link
Contributor

/approve

@sjenning
Copy link
Contributor

cc @JoelSpeed

@JoelSpeed
Copy link
Contributor

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, sjenning, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c38b556 and 2 for PR HEAD 0be88df in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 10a8fa5 and 1 for PR HEAD 0be88df in total

@JoelSpeed
Copy link
Contributor

/skip
/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 0be88df in total

5 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 0be88df in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 0be88df in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 0be88df in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 0be88df in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 0be88df in total

@JoelSpeed
Copy link
Contributor

/test e2e-aws-serial-techpreview

@JoelSpeed
Copy link
Contributor

What is the impact of this does not merge in time for 4.19 branching?

@vrutkovs
Copy link
Member Author

Only devpreview users would be affected - and they are not supported anyway

@JoelSpeed
Copy link
Contributor

Does the feature work to a point? Or would it be crippling the dev preview clusters? I'm some way?

@vrutkovs
Copy link
Member Author

Yes, it works - it issues shorter certificates. It won't cripple them, however we may see an elevated number of disruptions (if components are rotating certificates incorrectly).

@JoelSpeed
Copy link
Contributor

Thanks for the explanation.

I'm conscious of CI instability and a large number of features trying to squeeze PRs into this repo right now.

Given that every merge wipes the slate for other merges, and it's a minimum 4 hour turnaround time, we need to be careful about what merges and what doesn't.

Based on the description above, and our expected usage of Dev preview, I think we may want to skip this PR for now and prioritise stable feature promotions.

We can either hold this, or close it

@vrutkovs
Copy link
Member Author

I'd prefer to hold it so that we wouldn't forget about it. I'll retest this some time next week when nightlies are stabilized

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 0be88df in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 0be88df in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7680e1 and 2 for PR HEAD 0be88df in total

@JoelSpeed
Copy link
Contributor

/hold for now to see if we can get those trying to GA through

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 18, 2025

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 0be88df link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure 0be88df link false /test e2e-azure
ci/prow/verify-client-go 0be88df link true /test verify-client-go
ci/prow/e2e-aws-serial-techpreview 0be88df link true /test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vrutkovs @sjenning @JoelSpeed @openshift-ci-robot @openshift-merge-robot