Skip to content

OCPCLOUD-2914: Add MAPI to CAPI migration to TechPreview #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

OCPCLOUD-2914: Add MAPI to CAPI migration to TechPreview #2279

merged 3 commits into from
Apr 24, 2025
+293 −14

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Apr 14, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci bot
Loading

@nrb: This pull request references OCPCLOUD-2914 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Enabling the MAPI to CAPI conversion in TechPreview for 4.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

Hello @nrb! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci bot
Loading

@nrb: This pull request references OCPCLOUD-2914 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Enabling the MAPI to CAPI conversion in TechPreview for 4.19.

Required before merging:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed April 14, 2025 15:34
@nrb
Copy link
Contributor Author

nrb commented Apr 14, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2025
JoelSpeed
JoelSpeed reviewed Apr 14, 2025
View reviewed changes
features/features.go Outdated
@@ -599,6 +599,7 @@ var (
contactPerson("jspeed").
productScope(ocpSpecific).
enhancementPR(legacyFeatureGateWithoutEnhancement).
enableIn(configv1.TechPreviewNoUpgrade).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything enabled in TPNU must also be enabled in DPNU

Suggested change
enableIn(configv1.TechPreviewNoUpgrade).
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).

@nrb
Add MAPI to CAPI migration to TechPreview
6c88d8d 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2025 •
edited by openshift-ci bot
Loading

@nrb: This pull request references OCPCLOUD-2914 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Enabling the MAPI to CAPI conversion in TechPreview for 4.19.

Required before merging:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nrb
Generate manifests for MAPI TP
ac42cde 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 16, 2025
@shellyyang1989
Copy link

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2025 •
edited by openshift-ci bot
Loading

@nrb: This pull request references OCPCLOUD-2914 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Enabling the MAPI to CAPI conversion in TechPreview for 4.19.

Required before merging:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nrb
Allow CPMSMachineNamePrefix tests to run in TP
153be5c 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
damdo
damdo reviewed Apr 17, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2025
@shellyyang1989
Copy link

/retest

@shellyyang1989
Copy link

shellyyang1989 commented Apr 18, 2025 •
edited
Loading

Install failed due to running out of quota.
level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed during pre-provisioning: failed to create IAM roles: failed to create IAM master role: failed to create master role: LimitExceeded: Cannot exceed quota for RolesPerAccount: 1000

@damdo
Copy link
Member

damdo commented Apr 18, 2025

/retest

@damdo
Copy link
Member

damdo commented Apr 19, 2025

/hold

/retest

@damdo
Copy link
Member

damdo commented Apr 19, 2025

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 19, 2025

@damdo: The following commands are available to trigger required jobs:

/test build

/test e2e-aws-ovn

/test e2e-aws-ovn-hypershift

/test e2e-aws-ovn-hypershift-conformance

/test e2e-aws-ovn-techpreview

/test e2e-aws-serial

/test e2e-aws-serial-techpreview

/test e2e-upgrade

/test e2e-upgrade-out-of-change

/test images

/test integration

/test lint

/test minor-e2e-upgrade-minor

/test minor-images

/test unit

/test verify

/test verify-client-go

/test verify-crd-schema

/test verify-deps

/test verify-feature-promotion

The following commands are available to trigger optional jobs:

/test e2e-azure

/test e2e-gcp

/test okd-scos-e2e-aws-ovn

/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-api-master-build

pull-ci-openshift-api-master-e2e-aws-ovn

pull-ci-openshift-api-master-e2e-aws-ovn-hypershift

pull-ci-openshift-api-master-e2e-aws-ovn-hypershift-conformance

pull-ci-openshift-api-master-e2e-aws-ovn-techpreview

pull-ci-openshift-api-master-e2e-aws-serial

pull-ci-openshift-api-master-e2e-aws-serial-techpreview

pull-ci-openshift-api-master-e2e-azure

pull-ci-openshift-api-master-e2e-gcp

pull-ci-openshift-api-master-e2e-upgrade

pull-ci-openshift-api-master-e2e-upgrade-out-of-change

pull-ci-openshift-api-master-images

pull-ci-openshift-api-master-integration

pull-ci-openshift-api-master-lint

pull-ci-openshift-api-master-minor-e2e-upgrade-minor

pull-ci-openshift-api-master-minor-images

pull-ci-openshift-api-master-okd-scos-e2e-aws-ovn

pull-ci-openshift-api-master-unit

pull-ci-openshift-api-master-verify

pull-ci-openshift-api-master-verify-client-go

pull-ci-openshift-api-master-verify-crd-schema

pull-ci-openshift-api-master-verify-deps

pull-ci-openshift-api-master-verify-feature-promotion

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shellyyang1989
Copy link

/test e2e-aws-ovn-techpreview

@shellyyang1989
Copy link

seems like CCO was not working well

2025-04-19T11:09:14.136187092Z I0419 11:09:14.136165       1 recorder.go:104] "msg"="error creating aws client: aws credentials secret openshift-machine-api/aws-cloud-credentials: Secret \"aws-cloud-credentials\" not found not found" "logger"="events" "object"={"kind":"MachineSet","namespace":"openshift-machine-api","name":"ci-op-gcz4mxd4-286d2-x69v4-worker-us-west-1b","uid":"78c133a8-1707-445b-8d43-88363111b465","apiVersion":"machine.openshift.io/v1beta1","resourceVersion":"11107"} "reason"="ReconcileError" "type"="Warning"
2025-04-19T11:09:14.145622955Z I0419 11:09:14.145602       1 warning_handler.go:65] "msg"="providerSpec.credentialsSecret: Invalid value: \"aws-cloud-credentials\": not found. Expected CredentialsSecret to exist" "logger"="KubeAPIWarningLogger"
2025-04-19T11:09:14.145829170Z E0419 11:09:14.145813       1 controller.go:341] "msg"="Reconciler error" "error"="error creating aws client: aws credentials secret openshift-machine-api/aws-cloud-credentials: Secret \"aws-cloud-credentials\" not found not found" "MachineSet"={"name":"ci-op-gcz4mxd4-286d2-x69v4-worker-us-west-1b","namespace":"openshift-machine-api"} "controller"="machineset" "controllerGroup"="machine.openshift.io" "controllerKind"="MachineSet" "name"="ci-op-gcz4mxd4-286d2-x69v4-worker-us-west-1b" "namespace"="openshift-machine-api" "reconcileID"="a1bf60c2-1fd3-4821-93d5-0b0509db8c8a"

@shellyyang1989
Copy link

Failed again due to dns leaking?

level=info msg=Credentials loaded from the "default" profile in file "/var/run/secrets/ci.openshift.io/cluster-profile/.awscred"
level=fatal msg=failed to fetch Cluster Infrastructure Variables: failed to fetch dependency of "Cluster Infrastructure Variables": failed to generate asset "Platform Provisioning Check": baseDomain: Invalid value: "origin-ci-int-aws.dev.rhcloud.com": the zone already has record sets for the domain of the cluster: [api.ci-op-gcz4mxd4-286d2.origin-ci-int-aws.dev.rhcloud.com. (A)]
Installer exit with code 1

@shellyyang1989
Copy link

/test e2e-aws-serial-techpreview

@JoelSpeed
Copy link
Contributor

/retest

@nrb
Copy link
Contributor Author

nrb commented Apr 21, 2025

I believe AWS quota issues are cleared up now.

/retest

@nrb
Copy link
Contributor Author

nrb commented Apr 22, 2025

/retest-required

1 similar comment
@shellyyang1989
Copy link

/retest-required

@JoelSpeed
Copy link
Contributor

/hold cancel

Pre-requisites appear to have all merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f636181 and 2 for PR HEAD 153be5c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8b803ad and 1 for PR HEAD 153be5c in total

@nrb
Copy link
Contributor Author

nrb commented Apr 22, 2025

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9aa03e6 and 0 for PR HEAD 153be5c in total

@openshift-ci-robot
Copy link

/hold

Revision 153be5c was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2025
@JoelSpeed
Copy link
Contributor

/retest

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9aa03e6 and 2 for PR HEAD 153be5c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6bababe and 1 for PR HEAD 153be5c in total

@damdo
Copy link
Member

damdo commented Apr 23, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6bababe and 2 for PR HEAD 153be5c in total

@damdo
Copy link
Member

damdo commented Apr 24, 2025

/retest-required

1 similar comment
@shellyyang1989
Copy link

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@nrb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit eb41266 into openshift:master Apr 24, 2025
24 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202504241347.p0.geb41266.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@damdo damdo

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nrb @openshift-ci-robot @shellyyang1989 @damdo @JoelSpeed @openshift-bot