Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-45901: Remove namespace from ConsolePlugin YAML #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-45901: Remove namespace from ConsolePlugin YAML #73

wants to merge 1 commit into from

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Dec 9, 2024

The ConsolePlugin resource is cluster-scoped. It should not have a metadata.namespace in its YAML manifest.

Fixes #72

/assign @jhadvig

@spadgett
OCPBUGS-45901: Remove namespace from ConsolePlugin YAML
6227b18 
The ConsolePlugin resource is cluster-scoped. It should not have a
`metadata.namespace` in its YAML manifest.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 9, 2024
@openshift-ci-robot
Copy link

@spadgett: This pull request references Jira Issue OCPBUGS-45901, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The ConsolePlugin resource is cluster-scoped. It should not have a metadata.namespace in its YAML manifest.

Fixes #72

/assign @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
jhadvig
jhadvig approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@jhadvig
Copy link
Member

jhadvig commented Dec 10, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

5 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@spadgett
Copy link
Member Author

@jhadvig The tests might be broken in this repo :/ I don't believe the failure is from this change.

@spadgett
Copy link
Member Author 

No elements in the current DOM matched your query:

  > cy.get([data-test="user-dropdown"])

Because this error occurred during a `after all` hook we are skipping the remaining tests in the current suite: `Console plugin template test`

Maybe related to external OIDC changes?

@spadgett
Copy link
Member Author

I suspect this was caused by openshift/console#14547. We might have to revert that since it will break Cypress tests for plugins based on the template.

@logonoff FYI

@spadgett
Copy link
Member Author

The check for errors is wrong here now:

https://github.com/openshift/console-plugin-template/blob/main/integration-tests/support/index.ts#L6

@spadgett spadgett mentioned this pull request Dec 13, 2024
Open
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

3 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

6 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b0841e5 and 2 for PR HEAD 6227b18 in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 23, 2024

@spadgett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-plugin-template 6227b18 link true /test e2e-aws-plugin-template

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@yapei yapei Awaiting requested review from yapei

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

Assignees

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Namespace is redundant in the ConsolePlugin CR as ConsolePlugin has cluster scope
3 participants
@spadgett @openshift-ci-robot @jhadvig