OCPBUGS-46415: Revert "OCPBUGS-44920: save all window.windowErrors for easier debugging"
#14624
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@spadgett: This pull request references Jira Issue OCPBUGS-44920, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
component/sdk
spadgett
changed the title
window.windowErrors for easier debugging"window.windowErrors for easier debugging"
|
@spadgett: This pull request references Jira Issue OCPBUGS-46415, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@spadgett: This pull request references Jira Issue OCPBUGS-46415, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
| @@ -108,10 +108,9 @@ export const init = () => { | |||
| }, | |||
| saveMissing: true, | |||
| missingKeyHandler: function (lng, ns, key) { | |||
| const error = `Missing i18n key "${key}" in namespace "${ns}" and language "${lng}".`; | |||
| window.windowError = [...(window.windowError || []), error]; // OCPBUGS-45139: store all i18n errors for easy debugging | |||
| window.windowError = `Missing i18n key "${key}" in namespace "${ns}" and language "${lng}".`; | |||
There was a problem hiding this comment.
I think instead of doing a full revert we can keep OCPBUGS-44920 fixed by appending new errors to the windowError string
|
@spadgett: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/close superseded by #14653 |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@logonoff: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@spadgett: This pull request references Jira Issue OCPBUGS-46415. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Reverts #14547
See openshift/console-plugin-template#73 (comment). This original change causes plugins that use the Cypress utilities from the openshift/console-plugin-template repo to fail.