Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-44861: Set azure disk & file Secrets Store CSI Volume #324

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-44861: Set azure disk & file Secrets Store CSI Volume #324

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #309

/assign bryan-cox

@bryan-cox
Set azure disk & file Secrets Store CSI Volume
8567445 
Set the azure-disk and azure-file Secrets Store CSI volumes and volume
mounts when the following environment variables are passed to the
csi-operator pod - ARO_HCP_SECRET_PROVIDER_CLASS_FOR_FILE,
ARO_HCP_SECRET_PROVIDER_CLASS_FOR_DISK.

Signed-off-by: Bryan Cox <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 21, 2024
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: HOSTEDCP-2032

In response to this:

This is an automated cherry-pick of #309

/assign bryan-cox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign dobsonj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bryan-cox
Copy link
Member

/retitle [release-4.17] OCPBUGS-44861: Set azure disk & file Secrets Store CSI Volume

@openshift-ci openshift-ci bot changed the title [release-4.17] HOSTEDCP-2032: Set azure disk & file Secrets Store CSI Volume [release-4.17] OCPBUGS-44861: Set azure disk & file Secrets Store CSI Volume Nov 21, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-44861, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-44627 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #309

/assign bryan-cox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-44861, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-44627 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@mpatlasov mpatlasov Awaiting requested review from mpatlasov

Assignees

@bryan-cox bryan-cox

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @bryan-cox