Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: ask for backup/restore considerations #1707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maiqueb
Copy link
Contributor

@maiqueb maiqueb commented Oct 24, 2024

We have designed features without any regard for backup/restore of the cluster, and it shows.

For instance, the primary UDN impacted API is not idempotent: if we provision the namespaces and workloads first, and only then the NADs / UDNs, the network topology will look totally different, which might give the user something other than what they desired in the first place.

@maiqueb
Copy link
Contributor Author

maiqueb commented Oct 24, 2024

@dhellmann

Not sure this deserves a specific section, or if a highlighted sentence in the Implementation details would be enough.

Thoughts ?

@openshift-ci openshift-ci bot requested review from bn222 and dry923 October 24, 2024 10:58
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bear-redhat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

@maiqueb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2024
@maiqueb
Copy link
Contributor Author

maiqueb commented Nov 22, 2024

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2024
@maiqueb
Copy link
Contributor Author

maiqueb commented Nov 22, 2024

@dhellmann ping ... could you take a look ?

@JoelSpeed / @bparees I see you've updated the template in the past ... What do you think of this change ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants