CORS-3741: Nutanix enhancement: allow multiple NICs #1711
Conversation
|
@yanhua121: This pull request references CORS-3741 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@yanhua121: This pull request references CORS-3741 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @JoelSpeed |
There was a problem hiding this comment.
As presented, this looks pretty straight forward. The API fields already exist in the install config and also machine API. So it is mostly a matter of relaxing validation.
Are NICs handled transparently? i.e. all that needs to happen is more subnets are specified in the API and then NICs are created automagically for those subnets?
There is no reference to CAPI support. The CAPI manifests used by the installer to create the control plane would likely need to be updated as well.
|
@yanhua121: This pull request references CORS-3741 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
yanhua121
force-pushed
the
CORS-3741
branch
3 times, most recently
from
1c57780 to
780d14e
Compare
|
Apart from my outstanding question about software and the markdownlint being sad, I'm ok with what's written here, thanks @huali9 |
|
/assign @rvanderp3 |
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/retest |
1 similar comment
|
/retest |
|
@yanhua121: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
CORS-3741:
Nutanix machine-api enhancements: Multi-NICs for OCP Cluster Nodes
The enhancement PR for this:
#1711