Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1306: Update LSO enhancement for symlink cleanup #1717

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Nov 20, 2024

https://issues.redhat.com/browse/STOR-1306
/cc @openshift/storage @gnufied

Updating the enhancement to reflect the implemented changes in openshift/local-storage-operator#504

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2024

@dobsonj: This pull request references STOR-1306 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/STOR-1306
/cc @openshift/storage @gnufied

Updating the enhancement to reflect the implemented changes in openshift/local-storage-operator#504

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2024
@openshift-ci openshift-ci bot requested a review from gnufied November 20, 2024 18:45
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

https://issues.redhat.com/browse/STOR-1306
/cc @openshift/storage @gnufied

Updating the enhancement to reflect the implemented changes in openshift/local-storage-operator#504

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gnufied
Copy link
Member

gnufied commented Nov 20, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@gnufied
Copy link
Member

gnufied commented Dec 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Dec 4, 2024

/assign @jsafrane
for approval

@jsafrane
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f132d2a into openshift:master Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants