OCPBUGS-50915: Disable capi machineset preflights #5653
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@enxebre: This pull request references Jira Issue OCPBUGS-50915, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
enxebre
force-pushed
the
diable-machineset-preflight
branch
from
162fcfb to
304406c
Compare
openshift-ci
bot
added
the
area/hypershift-operator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
|
/lgtm |
This enabled machineset preflights by default kubernetes-sigs/cluster-api#11228 We want to disable this functionality in hcp because of the following reasons: MachineSetPreflightCheckControlPlaneIsStable We currently don't express intent for a version via spec.version but via spec.release MachineSetPreflightCheckKubernetesVersionSkew We preserve our ability to control our skew policy at a higher layer i.e. NodePool API MachineSetPreflightCheckKubeadmVersionSkew We don't run kubeadmin at all.
enxebre
force-pushed
the
diable-machineset-preflight
branch
from
304406c to
b5cdebc
Compare
|
/lgtm |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@enxebre: This pull request references Jira Issue OCPBUGS-50915, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/test e2e-aws-4-18 |
|
@enxebre: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override "Red Hat Konflux / hypershift-operator-main-on-pull-request" |
|
@enxebre: Overrode contexts on behalf of enxebre: Red Hat Konflux / hypershift-operator-main-on-pull-request In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Red Hat Konflux / hypershift-operator-main-on-pull-request" |
|
@enxebre: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Red Hat Konflux / hypershift-operator-main-on-pull-request" |
|
@enxebre: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This enabled machineset preflights by default kubernetes-sigs/cluster-api#11228
We want to disable this functionality in hcp because of the following reasons:
We currently don't express intent for a version via spec.version but via spec.release
We preserve our ability to control our skew policy at a higher layer i.e. NodePool API
We don't run kubeadmin at all.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist