Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-45203: LokiStack gatherer #1051

Open
wants to merge 2 commits into
base: release-4.16
Choose a base branch
from
Open

[release-4.16] OCPBUGS-45203: LokiStack gatherer #1051

wants to merge 2 commits into from

Conversation

joselsegura
Copy link
Contributor

This is a manual cherry-pick of #1022 and #1043

/assign openshift-ci-robot

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 10, 2024
@openshift-ci-robot
Copy link
Contributor

@joselsegura: This pull request references Jira Issue OCPBUGS-45202, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.17.z" instead
  • expected dependent Jira Issue OCPBUGS-45201 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-45201 to target a version in 4.17.0, 4.17.z, but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #1022 and #1043

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ncaak and tremes December 10, 2024 09:20
@joselsegura
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 12, 2024
Merged
@joselsegura
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@joselsegura: This pull request references Jira Issue OCPBUGS-45202, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.17.z" instead
  • expected dependent Jira Issue OCPBUGS-45201 to target a version in 4.17.0, 4.17.z, but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joselsegura joselsegura changed the title [release-4.16] OCPBUGS-45202: LokiStack gatherer [release-4.16] OCPBUGS-45203: LokiStack gatherer Dec 12, 2024
@openshift-ci-robot
Copy link
Contributor

@joselsegura: This pull request references Jira Issue OCPBUGS-45203, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-45202 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #1022 and #1043

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joselsegura
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@joselsegura: This pull request references Jira Issue OCPBUGS-45203, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-45202 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joselsegura
OCPBUGS-45047: LokiStack gatherer (openshift#1022)
f1c1776 
* Adding LokiStack gatherer

* Pay attention to error

* Gathering at most 20. Anonymizing the results to remove tenant's selectors

* Fix behaviour

* Solving some misunderstandings

* Make lintian happy again

* Updating docs

* Added unit tests

* Fix linter

* Tests table-strategy

* Fix linters

* Answering review
@joselsegura
OCPBUGS-45047: Avoid to send the same error repeated N times (openshi…
29069f5 
…ft#1043)

* Avoid to send the same error repeated N times

* Fix the LokiStack gatherer documentation
@joselsegura joselsegura force-pushed the cherry-pick-1022-to-release-4.16 branch from 49cf02e to 29069f5 Compare December 13, 2024 15:30
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joselsegura
Once this PR has been reviewed and has the lgtm label, please assign tremes for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joselsegura
Copy link
Contributor Author

/jira refresh

@joselsegura
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@joselsegura: This pull request references Jira Issue OCPBUGS-45203, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-45202 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 13, 2024

@joselsegura: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint 29069f5 link true /test lint
ci/prow/e2e-gcp-ovn-techpreview 29069f5 link true /test e2e-gcp-ovn-techpreview
ci/prow/insights-operator-e2e-tests 29069f5 link true /test insights-operator-e2e-tests
ci/prow/images 29069f5 link true /test images
ci/prow/unit 29069f5 link true /test unit
ci/prow/e2e-agnostic-upgrade 29069f5 link true /test e2e-agnostic-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 29069f5 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e 29069f5 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncaak ncaak Awaiting requested review from ncaak

@tremes tremes Awaiting requested review from tremes

Assignees

@openshift-ci-robot openshift-ci-robot

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joselsegura @openshift-ci-robot