OCPBUGS-38727: Enable Insight Operator entitlements for multi arch clusters #979
Conversation
joselsegura
force-pushed
the
improve_gather_archs
branch
from
d1e64fb to
6c3de61
Compare
|
/override ci/prow/insights-operator-e2e-tests |
|
@joselsegura: joselsegura unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thank you! |
|
/override ci/prow/insights-operator-e2e-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joselsegura, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-agnostic-upgrade, ci/prow/insights-operator-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tremes
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@joselsegura: This pull request references CCXDEV-14145 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
New changes are detected. LGTM label has been removed. |
joselsegura
changed the title
|
@joselsegura: This pull request references CCXDEV-12875 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@joselsegura: This pull request references CCXDEV-12875 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
joselsegura
force-pushed
the
improve_gather_archs
branch
from
2cc0d0e to
0c186ec
Compare
| @@ -33,7 +33,7 @@ import ( | |||
| const ( | |||
| responseBodyLogLen = 1024 | |||
| insightsReqId = "x-rh-insights-request-id" | |||
| scaArchPayload = `{"type": "sca","arch": "x86_64"}` | |||
There was a problem hiding this comment.
Hey @Prashanth684 @aleskandro since we have multi-arch compute.... I'm assuming this would not work? Thoughts? Thanks, Paul
There was a problem hiding this comment.
just read the rest of the code... makes sense
|
|
||
| // gatherArchitectures connects to K8S API to retrieve the list of | ||
| // nodes and create a set of the present architectures | ||
| func (c *Controller) gatherArchitectures(ctx context.Context) (map[string]struct{}, error) { |
There was a problem hiding this comment.
it might be best to request all arches. MachineSets could be on an autoscaler when the gather action is executed.
There was a problem hiding this comment.
I don't get your point. This method is requesting all archs from the nodes list returned by k8s API. Could you please elaborate more?
There was a problem hiding this comment.
Right - I see that. Since you can scale machinesets from zero, you may be temporarily excluding some arches from your retrieval.
There was a problem hiding this comment.
Example https://issues.redhat.com/browse/OCPBUGS-27509 and these would be the second set of MachineSets created.
There was a problem hiding this comment.
I get your point now. If at the moment of retrieving the nodes list some machineset is scaled to 0, how can I get the node architecture? I think we can only gather the arch for the current existing nodes, not from those that are unavailable because any reason, but maybe there is another way to retrieve the nodes list...
There was a problem hiding this comment.
I think there is a CVO task in the backlog https://issues.redhat.com/browse/MULTIARCH-4559
Maybe the right option is to load from a config, if missing getting the nodelist?
|
/override ci/prow/insights-operator-e2e-tests |
|
@joselsegura: joselsegura unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/insights-operator-e2e-tests |
|
@BaiyangZhou: BaiyangZhou unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/insights-operator-e2e-tests |
|
@ncaak: Overrode contexts on behalf of ncaak: ci/prow/insights-operator-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
joselsegura
changed the title
openshift-ci-robot
added
the
jira/valid-bug
|
@joselsegura: This pull request references Jira Issue OCPBUGS-38727, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@joselsegura: This pull request references Jira Issue OCPBUGS-38727, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
joselsegura
force-pushed
the
improve_gather_archs
branch
from
2ba37c6 to
1a3bd69
Compare
|
@joselsegura: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hey @joselsegura will this be merged at some point? |
This PR implements a new mechanism to gather a set of architectures used by nodes in the current cluster.
This set of architectures is not used yet, but if Insights Operator is not able to retrieve it, it will make the entitlements retrieval process to fail
Categories
Sample Archive
The archive won't change with this feature
Documentation
No documentation update
Unit Tests
No tests were updated
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
No
Breaking Changes
No
References
https://issues.redhat.com/browse/OCPBUGS-38727