OCPBUGS-49784: handle runtime panic when validating ovnKubernetesConfig

[tthvo]

When a clusternetwork entry has an invalid hostPrefix, which is <= CIDR mask and the custom IPv4 join subnet is provided in the install-config, the installer gives a runtime panic error: negative shift amount.

This introduces a check to return a more user-friendly and descriptive error message instead of runtime panic.

[openshift-ci-robot]

@tthvo: This pull request references Jira Issue OCPBUGS-49784, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When a clusternetwork entry has an invalid hostPrefix, which is <= CIDR mask and the custom IPv4 join subnet is provided in the install-config, the installer gives a runtime panic error: negative shift amount.

This introduces a check to return a more user-friendly and descriptive error message instead of runtime panic.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

/cc @patrickdillon

[openshift-ci]

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	bdeee29	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-multi-network	bdeee29	link	false	/test e2e-vsphere-ovn-multi-network
ci/prow/e2e-vsphere-static-ovn	bdeee29	link	false	/test e2e-vsphere-static-ovn
ci/prow/e2e-vsphere-externallb-ovn	bdeee29	link	false	/test e2e-vsphere-externallb-ovn
ci/prow/e2e-vsphere-host-groups-ovn-custom-no-upgrade	bdeee29	link	false	/test e2e-vsphere-host-groups-ovn-custom-no-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[patrickdillon]

/approve
/lgtm
/label acknowldege-critical-fixes-only
/cherry-pick release-4.18

[openshift-cherrypick-robot]

@patrickdillon: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/approve
/lgtm
/label acknowldege-critical-fixes-only
/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@patrickdillon: The label(s) /label acknowldege-critical-fixes-only cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/approve
/lgtm
/label acknowldege-critical-fixes-only
/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tthvo]

/label acknowledge-critical-fixes-only

small typo :D

[openshift-ci-robot]

@tthvo: Jira Issue OCPBUGS-49784: All pull requests linked via external trackers have merged:

• openshift/installer#9432

Jira Issue OCPBUGS-49784 has been moved to the MODIFIED state.

In response to this:

When a clusternetwork entry has an invalid hostPrefix, which is <= CIDR mask and the custom IPv4 join subnet is provided in the install-config, the installer gives a runtime panic error: negative shift amount.

This introduces a check to return a more user-friendly and descriptive error message instead of runtime panic.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@patrickdillon: new pull request created: #9435

In response to this:

/approve
/lgtm
/label acknowldege-critical-fixes-only
/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202502042306.p0.g7cfff77.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.19.0-202502042306.p0.g7cfff77.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.19.0-202502042306.p0.g7cfff77.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.19.0-202502042306.p0.g7cfff77.assembly.stream.el9.
All builds following this will include this PR.