Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-49737: GCP: Include the gcp-routes.service for all GCP installs #4969

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

sadasu
Copy link
Contributor

@sadasu sadasu commented Apr 3, 2025

- What I did
The openshift-gcp-routes service is required eve during GCP installs with in-cluster DNS. During some early work on the in-cluster DNS feature, I had concluded that this service may not be necessary. After testing the in-cluster DNS further it is clear that this service is required even in this case.

- How to verify it
Enable userProvisionedDNS via install-config for GCP platform

- Description for the changelog

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2025
Copy link
Contributor

openshift-ci bot commented Apr 4, 2025

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 357209f link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/bootstrap-unit 357209f link false /test bootstrap-unit
ci/prow/e2e-agent-compact-ipv4 357209f link false /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sadasu sadasu changed the title WIP: GCP: Adding back the gcp-routes.service for all GCP installs OCPBUGS-49737: GCP: Include the gcp-routes.service for all GCP installs Apr 4, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 4, 2025
@openshift-ci-robot
Copy link
Contributor

@sadasu: This pull request references Jira Issue OCPBUGS-49737, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianli-wei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jianli-wei April 4, 2025 18:34
@openshift-ci-robot
Copy link
Contributor

@sadasu: This pull request references Jira Issue OCPBUGS-49737, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianli-wei

In response to this:

- What I did
The openshift-gcp-routes service is required eve during GCP installs with in-cluster DNS. During some early work on the in-cluster DNS feature, I had concluded that this service may not be necessary. After testing the in-cluster DNS further it is clear that this service is required even in this case.

- How to verify it
Enable userProvisionedDNS via install-config for GCP platform

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sadasu
Copy link
Contributor Author

sadasu commented Apr 7, 2025

/retest-required

@djoshy
Copy link
Contributor

djoshy commented Apr 7, 2025

/lgtm

/hold

holding for pre merge QE

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2025
@djoshy
Copy link
Contributor

djoshy commented Apr 7, 2025

/unhold

just saw that it has been tested on the attached bug

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2025
Copy link
Contributor

openshift-ci bot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2e9e507 into openshift:main Apr 7, 2025
14 of 17 checks passed
@openshift-ci-robot
Copy link
Contributor

@sadasu: Jira Issue OCPBUGS-49737: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49737 has been moved to the MODIFIED state.

In response to this:

- What I did
The openshift-gcp-routes service is required eve during GCP installs with in-cluster DNS. During some early work on the in-cluster DNS feature, I had concluded that this service may not be necessary. After testing the in-cluster DNS further it is clear that this service is required even in this case.

- How to verify it
Enable userProvisionedDNS via install-config for GCP platform

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants