-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-49737: GCP: Include the gcp-routes.service for all GCP installs #4969
Conversation
@sadasu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@sadasu: This pull request references Jira Issue OCPBUGS-49737, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sadasu: This pull request references Jira Issue OCPBUGS-49737, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
/lgtm /hold holding for pre merge QE |
/unhold just saw that it has been tested on the attached bug |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2e9e507
into
openshift:main
@sadasu: Jira Issue OCPBUGS-49737: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-49737 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
- What I did
The openshift-gcp-routes service is required eve during GCP installs with in-cluster DNS. During some early work on the in-cluster DNS feature, I had concluded that this service may not be necessary. After testing the in-cluster DNS further it is clear that this service is required even in this case.
- How to verify it
Enable
userProvisionedDNS
via install-config for GCP platform- Description for the changelog