Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ART-12521: update go mod dependency for konflux #4974

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashwindasr
Copy link

Image build was failing on Konflux due to missing go mod dependencies.

2025-04-04 17:30:05,752 ERROR vendor directory changed after vendoring:
M	vendor/k8s.io/code-generator/generate-groups.sh
M	vendor/k8s.io/code-generator/generate-internal-groups.sh
2025-04-04 17:30:08,950 ERROR PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.

Konflux ignores .gitignore files since its a possible security gap.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2025

@ashwindasr: This pull request references ART-12521 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Image build was failing on Konflux due to missing go mod dependencies.

2025-04-04 17:30:05,752 ERROR vendor directory changed after vendoring:
M	vendor/k8s.io/code-generator/generate-groups.sh
M	vendor/k8s.io/code-generator/generate-internal-groups.sh
2025-04-04 17:30:08,950 ERROR PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.

Konflux ignores .gitignore files since its a possible security gap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashwindasr
Once this PR has been reviewed and has the lgtm label, please assign lorbuschris for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashwindasr
Copy link
Author

/retest

1 similar comment
@ashwindasr
Copy link
Author

/retest

Copy link
Contributor

openshift-ci bot commented Apr 5, 2025

@ashwindasr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit 21bb56e link false /test bootstrap-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants